Discuss latest changes to master before releasing

[jamiebuilds]

There are a lot of changes happening right now that have not been discussed, including breaking changes.

6d3100e...master

At the very least these should be pull requests that other contributors can discuss.

Changes include:

• Removing _.transform
• Removing _.create
• Renaming _.keysIn to _.allKeys
• Renaming _.mapValues to _.mapObject
• Renaming _.assign to _.extendOwn
• Renaming _.matches to _.isMatch
• Adding _.matcher alias _.matches
• Reverted some changes in 1.7 (ie. _.extend)

[jamiebuilds]

Well, too late I guess https://twitter.com/jashkenas/status/568564455937839106

[jashkenas]

Too late indeed. We can follow up with a 1.8.1 pronto if needed. Hopefully it won't be...

[jridgewell]

Renaming _.matches to _.isMatch
Adding _.matcher alias _.matches

Those were both fixed. 1.7's _.matches is 1.8's _.matcher = _.matches. 1.8's _.isMatch is what you expect it is.

[jridgewell]

Reverted some changes in 1.7 (ie. _.extend)

1.8 has the same behavior as 1.6, which is intentional b17bd67.

[jridgewell]

Do you mind cleaning up the ones that weren't changes made last minute by @jashkenas? _.matches, _.matcher, _.isMatch, and _.extend aren't undiscussed issues.

I'd love for this to be the jumping off point to fix 1.8 with 1.8.1. And this time, let's actually fix it.

[jridgewell]

Additionally, we have a breaking change to a brand new feature in 1.7: Overriding _.iteratee no longer changes the behavior of the collection iterators. Fix is #1965.

@jashkenas Please revoke 1.8 from npm. Let's get these issues worked out, and ship a 1.8.1.

[jashkenas]

I don't think we should allow overriding iteratee. It's not a very pleasant API — so that change is alright.

I'm more concerned about the IE8 test failures. What on earth happened to poor old IE?

[jridgewell]

I don't think we should allow overriding iteratee. It's not a very pleasant API — so that change is alright.

But #1582... and it was brand new!

[jridgewell]

Adding to this:

• IE non-enumerable property support has been removed in 1.8.1
  • Fixed
• Edge case tests were removed in 1.8.1
  • Fixed

[AdamHess]

Guys USE SEMVER! These sort of breaking changes should make this pump up a complete version number!

[jridgewell]

Closing this since there are relevant PRs for each of the changes.

• Removing _.transform
  • Add _.transform method #2075
• Removing _.create
  • Add _.create method #2074
• Renaming _.keysIn to _.allKeys
  • Alias allKeys to keysIn #2071
• Renaming _.mapValues to _.mapObject
  • Alias mapObject to mapValues #2073
• Renaming _.assign to _.extendOwn
  • Assign extendOwn #2070
• Renaming _.matches to _.isMatch
  • Add proper Object function matches #2057
• Adding _.matcher alias _.matches
  • Add proper Object function matches #2057
• Reverted some changes in 1.7 (ie. _.extend)
  • Non issue, b17bd67