Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Alias mapObject to mapValues #2073

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Alias mapObject to mapValues #2073

wants to merge 1 commit into from

Conversation

jridgewell
Copy link
Collaborator

For the record, I like _.mapObject better. But this change was undiscussed.

Re: #2061, 4f771e0

@jamiebuilds
Copy link
Contributor

_.mapValues makes more sense to me as you are only manipulating the values in the object and not the keys. _.mapObject implies a limited set of functionality that _.transform has.

@jridgewell jridgewell mentioned this pull request Feb 23, 2015
Closed
@megawac megawac mentioned this pull request Jun 12, 2015
Closed
6 tasks
@paulfalgout
Copy link
Contributor

👍

@captbaritone
Copy link
Collaborator

I like the alias, but the PR should also update tests.

@jridgewell
Alias mapObject to mapValues
c4038ba 
For the record, I like `_.mapObject` better. But this change was
undiscussed.

Re: jashkenas#2061, 4f771e0
@jridgewell
Copy link
Collaborator Author

@captbaritone: You got it. 😉

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jridgewell @jamiebuilds @paulfalgout @captbaritone @jgonggrijp