Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pip-compile includes irrelevant constraints from pip contraints file #417

Merged
merged 0 commits into from
Mar 22, 2017
Merged

pip-compile includes irrelevant constraints from pip contraints file #417

merged 0 commits into from
Mar 22, 2017

Conversation

derek-miller
Copy link
Contributor

@derek-miller derek-miller commented Nov 23, 2016

pip-compile treats constraints as requirements.

https://pip.pypa.io/en/stable/user_guide/#constraints-files

Steps to replicate
  1. Create a constraints.txt file with the following contents:
click==6  # Irrelevant package
itsdangerous==0.24
  1. Create a requirements.in file with the following contents:
-c constraints.txt
Flask
  1. run pip-compile
Expected result
#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile --output-file requirements.txt requirements.in
#

Flask==0.11.1
itsdangerous==0.24
Jinja2==2.8               # via flask
MarkupSafe==0.23          # via jinja2
Werkzeug==0.11.11         # via flask
Actual result
#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile --output-file requirements.txt requirements.in
#

click==6.0
Flask==0.11.1
itsdangerous==0.24
Jinja2==2.8               # via flask
MarkupSafe==0.23          # via jinja2
Werkzeug==0.11.11         # via flask

@derek-miller
Copy link
Contributor Author

@nvie I took a stab at this, I would appreciate it if you could take a look.

@derek-miller
Copy link
Contributor Author

@nvie Any chance you could take a look at this?

@derek-miller
Copy link
Contributor Author

@nvie?

suutari-ai added a commit to suutari/prequ that referenced this pull request Feb 8, 2017
* 'master' of github.com:derek-miller/pip-tools:
  Exclude irrelevant pip constraints from output (jazzband#417)
suutari-ai added a commit to suutari/prequ that referenced this pull request Feb 8, 2017
* pip-tools-integration:
  Exclude irrelevant pip constraints from output (jazzband#417)
suutari-ai added a commit to suutari/prequ that referenced this pull request Feb 9, 2017
Mark the merged PRs of pip-tools in Change Log more clearly so that it
is easier to keep track which fixes/features are already in.

This includes following 7 PRs:

  * jazzband#355
  * jazzband#378
  * jazzband#389
  * jazzband#417
  * jazzband#441
  * jazzband#448
  * jazzband#450
@derek-miller derek-miller merged commit a4ab7ce into jazzband:master Mar 22, 2017
@derek-miller
Copy link
Contributor Author

Github's PR user interaction is quite terrible and marked this as Merged when I was trying to rebase, forcing me to open another PR. See #471.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant