Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pip-compile includes irrelevant constraints from pip contraints file #471

Merged
merged 1 commit into from
Mar 31, 2017
Merged

pip-compile includes irrelevant constraints from pip contraints file #471

merged 1 commit into from
Mar 31, 2017

Conversation

derek-miller
Copy link
Contributor

pip-compile treats constraints as requirements.

https://pip.pypa.io/en/stable/user_guide/#constraints-files

Steps to replicate
  1. Create a constraints.txt file with the following contents:
click==6  # Irrelevant package
itsdangerous==0.24
  1. Create a requirements.in file with the following contents:
-c constraints.txt
Flask
  1. run pip-compile
Expected result
#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile --output-file requirements.txt requirements.in
#

Flask==0.11.1
itsdangerous==0.24
Jinja2==2.8               # via flask
MarkupSafe==0.23          # via jinja2
Werkzeug==0.11.11         # via flask
Actual result
#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile --output-file requirements.txt requirements.in
#

click==6.0
Flask==0.11.1
itsdangerous==0.24
Jinja2==2.8               # via flask
MarkupSafe==0.23          # via jinja2
Werkzeug==0.11.11         # via flask

@derek-miller
Copy link
Contributor Author

Anyone have time to review this?

@davidovich davidovich merged commit 62d85ea into jazzband:master Mar 31, 2017
@davidovich
Copy link
Contributor

Thanks @derek-miller !

@derek-miller derek-miller deleted the exclude-pip-constraints branch March 31, 2017 17:02
@davidovich
Copy link
Contributor

I have no problem with the fix, it's just that it works very well without the memoization... Would you mind taking #485 for a spin and see if your use case is broken ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants