Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix rename operations for a DFS path #191

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Fix rename operations for a DFS path #191

merged 2 commits into from
Aug 23, 2022

Conversation

jborean93
Copy link
Owner

Turns out the path is resolved correctly and I can use the DFS path to be normalized but I need to ensure

  • The DFS path is done as part of get_smb_tree so all callers get this new path
  • The header is build to include the DFS operation flag for more than just a CREATE request

Fixes: #170 (comment)

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #191 (2415aa4) into master (08b7dcf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          24       24           
  Lines        5076     5079    +3     
=======================================
+ Hits         5030     5033    +3     
  Misses         46       46           
Flag Coverage Δ
macOS 68.18% <33.33%> (-0.03%) ⬇️
py3.10 99.07% <100.00%> (+<0.01%) ⬆️
py3.7 99.07% <100.00%> (+<0.01%) ⬆️
py3.8 99.07% <100.00%> (+<0.01%) ⬆️
py3.9 99.09% <100.00%> (+<0.01%) ⬆️
ubuntu 96.78% <100.00%> (+<0.01%) ⬆️
windows 99.01% <100.00%> (+<0.01%) ⬆️
x64 99.09% <100.00%> (+<0.01%) ⬆️
x86 99.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/smbclient/_io.py 99.02% <ø> (-0.01%) ⬇️
src/smbclient/_os.py 98.49% <100.00%> (+0.01%) ⬆️
src/smbclient/_pool.py 95.93% <100.00%> (+0.04%) ⬆️
src/smbprotocol/connection.py 99.84% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STATUS_ACCESS_DENIED when write by dfs path before read
1 participant