Skip to content

Commit

Permalink
Do not cache the drop payload for SeoTag (#306)
Browse files Browse the repository at this point in the history
Merge pull request 306
  • Loading branch information
ashmaroli authored and jekyllbot committed Mar 16, 2019
1 parent ad3f7e3 commit 2f80d62
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion lib/jekyll-seo-tag.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,20 @@ def payload
end

def drop
@drop ||= Jekyll::SeoTag::Drop.new(@text, @context)
# TODO: Modify following comment once Jekyll 4.0 ships.
# ------------------------------------------------------------------------------------------
# Jekyll 4.0 is probably going to cache parsed Liquid Templates which is going to break the
# rendered output from this tag since there's going to be just a single instance of this
# class per {% seo %} in a template, (especially when the tag is used as part of an include).
# -------------------------------------------------------------------------------------------
#
# FIXME: Switch to using `if Gem::Version.new(Jekyll::VERSION) >= Gem::Version.new("4.0.0")`
# once Jekyll 4.0 ships.
if context.registers[:site].liquid_renderer.respond_to?(:cache)
Jekyll::SeoTag::Drop.new(@text, @context)
else
@drop ||= Jekyll::SeoTag::Drop.new(@text, @context)
end
end

def info
Expand Down

0 comments on commit 2f80d62

Please # to comment.