Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not cache the drop payload for SeoTag #306

Merged
merged 3 commits into from
Mar 16, 2019

Conversation

ashmaroli
Copy link
Member

For compatibility with Jekyll 4.0.. and current jekyll:master..

@DirtyF DirtyF requested review from benbalter and pathawks October 3, 2018 21:38
@joshgoebel
Copy link

Since we have the conditional is there a reason this is hung and not getting merged into master?

@ashmaroli
Copy link
Member Author

is there a reason this is hung

Perhaps the maintainers are waiting for Jekyll core to finalize whether the said "caching Liquid templates" enhancement would be included in the final release in order to avoid unnecessary code-churn...

Additionally, the conditional is a hack and as of now, the line
if context.registers[:site].liquid_renderer.respond_to?(:cache) would be executed for every call to the drop method, affecting performance in sites not willing to upgrade to Jekyll 4.x..

Lots of decisions to take..

@joshgoebel
Copy link

Good points. I don't think the if/else would be that slow, but I suppose you can argue it'd be potentially slower than nothing at all that we're currently doing. :-)

@jekyllbot jekyllbot merged commit 2f80d62 into jekyll:master Mar 16, 2019
jekyllbot added a commit that referenced this pull request Mar 16, 2019
@jekyllbot jekyllbot mentioned this pull request Mar 16, 2019
@DirtyF DirtyF mentioned this pull request Mar 16, 2019
21 tasks
maveille pushed a commit to maveille/jekyll-seo-tag that referenced this pull request Aug 3, 2019
maveille pushed a commit to maveille/jekyll-seo-tag that referenced this pull request Aug 3, 2019
@jekyll jekyll locked and limited conversation to collaborators Mar 15, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants