Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adapt to new CSP design #1839

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Adapt to new CSP design #1839

merged 4 commits into from
Nov 20, 2024

Conversation

timja
Copy link
Member

@timja timja commented Nov 20, 2024

see jenkinsci/csp-plugin#16

Testing done

Tested it works if no CSP violations, haven't managed to test with something with violations, artifactory plugin test won't run on my machine, artifactory just won't start.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@daniel-beck
Copy link
Member

Tested it works if no CSP violations, haven't managed to test with something with violations

Looks like LogParserTest is taking care of this for you?

@daniel-beck
Copy link
Member

Haven't looked at LogParser in detail what exactly is happening there, but there is a legitimate regression in the CSP plugin here: DBS via Resource Root URL is deliberately intended to not have CSP, but now does. WIP fix in jenkinsci/csp-plugin#19

@basil basil added the internal label Nov 20, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thank you!

@basil basil merged commit fdd6a49 into jenkinsci:master Nov 20, 2024
25 checks passed
@timja timja deleted the csp branch November 20, 2024 21:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants