Skip setting CSP header on resource root URL request #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #18, CSP headers are also set for files served by
DirectoryBrowserSupport
from "Resource Root URL" requests when that shouldn't be the case.This probably still clashes in some way with
hudson.model.DirectoryBrowserSupport.CSP
, TBD exactly (but that seems like a reasonable tradeoff, just needs to be documented).Testing done
Freestyle job with shell build step
echo '<script>alert(1)</script>' > index.html
. Navigate to the file in the workspace browser. With RRURL set, the script executes (as intended, was regressed), otherwise does not (as intended).Submitter checklist