JENKINS-74974 - Adapt Scriptler test to use preferred terminology #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much @mtughan |
MarkEWaite
approved these changes
Dec 10, 2024
MarkEWaite
changed the title
MarkEWaite
changed the title
|
I missed that JDK 17 would use an older version of Jenkins which installs an older version of the plugin without the name change. Let me work on fixing it now. |
mtughan
force-pushed
the
JENKINS-74974
branch
from
ed08f50 to
812bccd
Compare
Scriptler 390 and above use "(built-in)" to refer to the built-in node instead of "(controller)" or "(master)". Update the test harness to check for any of these terms. The adaptation code can be simplified once older versions of the Scriptler plugin are no longer being tested.
mtughan
force-pushed
the
JENKINS-74974
branch
from
812bccd to
2fe40d8
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-74974 - Adapt to Scriptler 390+
Scriptler 390 and above use "(built-in)" to refer to the built-in node instead of "(controller)" or "(master)" (jenkinsci/scriptler-plugin#128). Update the test harness to check for any of these terms.
The adaptation code can be simplified once older versions of the Scriptler plugin are no longer being tested.
Testing done
Tested the Scriptler unit tests locally.
Submitter checklist