Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to built-in node instead of controller #128

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mtughan
Copy link
Contributor

@mtughan mtughan commented Nov 26, 2024

The comment about running Scriptler scripts on the controller is somewhat incorrect and we should be talking about running on the built- in node instead. Make this change, as well as in the configuration data.

Adapts the code previously written in #127.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The comment about running Scriptler scripts on the controller is
somewhat incorrect and we should be talking about running on the built-
in node instead. Make this change, as well as in the configuration data.
@mtughan mtughan added the chore label Nov 26, 2024
@mtughan mtughan self-assigned this Nov 26, 2024
@mtughan mtughan mentioned this pull request Nov 26, 2024
6 tasks
@mtughan mtughan merged commit 28b28ff into jenkinsci:main Dec 2, 2024
17 checks passed
@mtughan mtughan deleted the switch-to-built-in branch December 2, 2024 12:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant