Fix form validation #646
Merged
Fix form validation #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FormValidation was failing as the structure of the validation changed. ``` Too many validation elements: [[[[[[[FirefoxDriver: firefox on LINUX (5967b81a-5dce-41f8-a115-117b72e60140)] -> css selector: [path='/useincluderegex/includeRegex']]] -> xpath: ./../../following-sibling::tr/td[2] | ./../following-sibling::div]] -> tag name: div], [[[[[[FirefoxDriver: firefox on LINUX (5967b81a-5dce-41f8-a115-117b72e60140)] -> css selector: [path='/useincluderegex/includeRegex']]] -> xpath: ./../../following-sibling::tr/td[2] | ./../following-sibling::div]] -> tag name: div], [[[[[[FirefoxDriver: firefox on LINUX (5967b81a-5dce-41f8-a115-117b72e60140)] -> css selector: [path='/useincluderegex/includeRegex']]] -> xpath: ./../../following-sibling::tr/td[2] | ./../following-sibling::div]] -> tag name: div], [[[[[[FirefoxDriver: firefox on LINUX (5967b81a-5dce-41f8-a115-117b72e60140)] -> css selector: [path='/useincluderegex/includeRegex']]] -> xpath: ./../../following-sibling::tr/td[2] | ./../following-sibling::div]] -> tag name: div]] ``` THis fixes the FormValidationTest (to some extent) however there is a bug in firefox that causes it not to show the alert when navigating away from a configuration page. works with chrome so this is at least a step in the right direction.
jtnord
force-pushed
the
fix-form-validation
branch
from
def3c3c to
21408b6
Compare
Vlatombe
reviewed
Feb 19, 2021
src/main/java/org/jenkinsci/test/acceptance/po/FormValidation.java
Outdated
Show resolved
Hide resolved
timja
approved these changes
Feb 19, 2021
…java Co-authored-by: Vincent Latombe <vincent@latombe.net>
|
optional reviewer: @raul-arabaolaza FYI |
MRamonLeon
reviewed
Feb 19, 2021
| @@ -67,23 +67,24 @@ public static FormValidation await(Control control) { | |||
|
|
|||
| // Special handling for validation buttons and their markup | |||
| if (element.getTagName().equals("button")) { | |||
| WebElement spinner = element.findElement(control.by.xpath("./../../../following-sibling::div[1]")); | |||
| WebElement spinner = element.findElement(by.xpath("./../../../following-sibling::div[1]")); | |||
There was a problem hiding this comment.
was control affecting by any means?
There was a problem hiding this comment.
by is a static field of CapybaraPortingLayer of which Control extends, So this is unrelated to the fix - just removing the "Field by of blah should be accessed in a static way" linting.
jtnord
commented
Feb 19, 2021
src/main/java/org/jenkinsci/test/acceptance/po/FormValidation.java
Outdated
Show resolved
Hide resolved
Vlatombe
approved these changes
Feb 19, 2021
MRamonLeon
approved these changes
Feb 19, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormValidationTesthas been reliably failing for a while.This fixes the cause of failure where the validation being selected was not the correct one.
possibly caused by jenkinsci/jenkins#5195
Given this is in the upcoming LTS and mainline I have not bothered about backwards compatibility.
e.g. https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/master/lastCompletedBuild/testReport/core/FormValidationTest/java_8_split9___validate/