Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[JENKINS-64429] Fix registerValidator breaking error messages #5195

Merged

Conversation

fqueiruga
Copy link
Contributor

@fqueiruga fqueiruga commented Jan 21, 2021

See JENKINS-64429.

Changes to the registerValidator function on 2.264 (tables-to-divs) introduced a bug where server-side validations would corrupt the .validation-error-area internal HTML structure. This caused regexp validators to break and to fail to show messages.

Proposed changelog entries

  • JENKINS-64429, Fixed error where server-side form validation would break validation on the client-side

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@timja
@amuniz
@jtnord

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@fqueiruga fqueiruga changed the title Fix bug registerValidator broking error messages [JENKINS-64429] Fix registerValidator breaking error messages Jan 21, 2021
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure if it works :)

@jtnord jtnord requested a review from timja January 21, 2021 11:53
@jtnord jtnord added the bug For changelog: Minor bug. Will be listed after features label Jan 21, 2021
Copy link
Member

@amuniz amuniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it's fixing the issue.

Also fixing JENKINS-64651 - which is the same thing.

Copy link
Contributor

@MRamonLeon MRamonLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 22, 2021
@timja
Copy link
Member

timja commented Jan 22, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja merged commit d40e470 into jenkinsci:master Jan 24, 2021
@fqueiruga fqueiruga deleted the JENKINS-64429_fix-registerValidator branch January 25, 2021 12:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants