Consistent Jelly version for commons-jelly-tags-fmt
#10128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently ship
commons-jelly-tags-fmt
1.0 from 19 years ago. While the fact that it has not needed any changes in 19 years is a testament to the quality of that code, we were not so lucky in jenkinsci/jelly#110 and jenkinsci/json-lib@b1fe8a3, both of which required us to patch and deliver changes to unmaintained third-party libraries via our forks. We were able to do both easily because we had a pipeline for delivering changes, which we do not currently have forcommons-jelly-tags-fmt
because the project is dead upstream.This PR solves this problem by switching our
commons-jelly-tags-fmt
JAR to the one built and deployed from our fork of Jelly. I compared the sources in our fork to that of https://repo1.maven.org/maven2/commons-jelly/commons-jelly-tags-fmt/1.0/commons-jelly-tags-fmt-1.0-sources.jar and, other than Javadoc updates for Java 11/17/21 compatibility, the sources were identical, so there is no risk here in terms of code change. The only difference in the JARs is that ours is now compiled with Java 17. More importantly, though, this allows us to deliver changes to this code in the future, should the need arise. Currently I do not anticipate such a need.A similar problem exists for
commons-jelly-tags-xml
, which I am explicitly not tackling here. I could not easily find the source files for what we are shipping today in https://repo1.maven.org/maven2/commons-jelly/commons-jelly-tags-xml/1.1/ and it is not immediately obvious to me whether or not we are even using this functionality. Some more effort would be required (a) to confirm that we are using this functionality and (b) to dig up the source code for what we are shipping today (or decompile the JAR) to confirm that switching to the sources in our fork would not be introducing a regression.Testing done
As mentioned above, confirmed that the only source code changes were changes to Javadoc comments, which carry a minimal to zero risk of regression. Automated testing should take care of the rest.
Jelly versions after this change:
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist