Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consistent Jelly version for commons-jelly-tags-xml #10131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

basil
Copy link
Member

@basil basil commented Jan 7, 2025

Like #10128, but for commons-jelly-tags-xml. See jenkinsci/jelly#144 for a description of the changes in this library. As of this PR all Jelly libraries in the WAR will be of a consistent version, and changes to Jelly can be tested easily. The only actual code change in this PR is apache/commons-jelly@357282d, which seems innocent enough and appears to be fully backward-compatible.

Testing done

Verified that no new JARs were in the WAR and that all Jelly JARs had a consistent version.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@basil basil added the skip-changelog Should not be shown in the changelog label Jan 7, 2025
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basil LGTM.

@basil basil self-assigned this Jan 8, 2025
@basil
Copy link
Member Author

basil commented Jan 8, 2025

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants