[JENKINS-27035] Gathering command read/write events

[jglick]

JENKINS-27035

Downstream of jenkinsci/remoting#204.

• JENKINS-27035 - new API in Remoting to listen to important Command events
• JENKINS-49027 - Remoting 3.17: Improve reporting of JEP-200 violations in Remoting serialization
• Full changelog: https://github.com/jenkinsci/remoting/blob/master/CHANGELOG.md#317

@reviewbybees

[daniel-beck]

Huh?

[jglick]

See cab2663 commit message.

[oleg-nenashev]

on hold till the new Remoting version gets released

[oleg-nenashev]

Uh oh, do we really have THAT in FilePath?

[oleg-nenashev]

I feel to could be moved to an API class in Remoting. E.g.

class LoggerChannelListener extends ChannelListener {
    private final Logger LOGGER;

    public LoggingChannelListener() {
       ...
    }    
 
    ... // all methods
}

Why? It may be useful to have the same logger for Remoting CLI, Maven Plugin and other custom implementations with Channel.

WDYT @jglick ?

[oleg-nenashev]

🐝 in general, but I feel the Logging listener should be an API class in Remoting itself

[jglick]

Pushing down the logging listener is a reasonable idea, though it is a little tricky since then core would either need to attach two listeners (slightly more runtime overhead) or subclass it (somewhat poor style).

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[oleg-nenashev]

I hope to release the Remoting side next week

[jglick]

Needs a few test fixes to keep up with jenkinsci/remoting#247.

[oleg-nenashev]

It will need an integration with the master branch once #3276 is released

[oleg-nenashev]

Crap, I forgot to merge it. #FOSDEM