Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[JENKINS-49027, JENKINS-27035] - Update Remoting to 3.17 #3276

Closed
wants to merge 1 commit into from
Closed

[JENKINS-49027, JENKINS-27035] - Update Remoting to 3.17 #3276

wants to merge 1 commit into from

Conversation

oleg-nenashev
Copy link
Member

Proposed changelog entries

JENKINS-27035 - changelog is not required, it will be added by #3071

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees @jglick @rysteboe

@oleg-nenashev oleg-nenashev requested review from jglick and a user January 31, 2018 17:31
@oleg-nenashev oleg-nenashev mentioned this pull request Jan 31, 2018
Merged
@oleg-nenashev oleg-nenashev added the needs-more-reviews Complex change, which would benefit from more eyes label Jan 31, 2018
jglick
jglick requested changes Feb 1, 2018
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures, which I already fixed in #3071. Why not just close this one, and update the proposed changelog entries in the other?

@oleg-nenashev
Copy link
Member Author

@jglick fine with me. Please modify the changelog there

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jglick jglick jglick requested changes

Assignees
No one assigned
Labels
needs-more-reviews Complex change, which would benefit from more eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleg-nenashev @jglick