Issue #6052 - make ModuleLocation optional on Android #6053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
requested changes
Mar 15, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
approved these changes
Mar 15, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how
ModuleLocationis loaded byTypeUtilto allow it be entirely optional.Also, change
jetty-client-<ver>-hybrid.jarto generate a minimized jar, which will only include the dependent classes that are actually used, not all classes from http/io/util.Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com