Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds new themes: Darcula and Gruvbox #138

Merged
merged 15 commits into from
Dec 22, 2023
Merged

Conversation

hayribakici
Copy link

@hayribakici hayribakici commented Apr 20, 2023

This PR fixes #32 and adds two more themes: Darcula (here called "Vlad") as addressed in #32 and gruvbox (here called "Groovy"). It also adds the navigationbarColor (not shown in the screenshots). It furthermor allows to have header text colors for distinguishing beetween headers and the contents of the screen. The header colors are not set in stone, however both of them are part of their respective color themes.

Also this PR adapts the textColor of the SwitchCompat button correctly.

"Vlad"

"Groovy"

* Darcula and GruvBox
@hayribakici hayribakici changed the title Adds new themes Adds new themes: Darcula and Gruvbox Apr 20, 2023
@hayribakici hayribakici marked this pull request as draft July 25, 2023 15:54
@hayribakici

This comment was marked as resolved.

@hayribakici hayribakici marked this pull request as ready for review October 10, 2023 20:24
Copy link
Collaborator

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome! if you could rebase, we'd be able to move it though pretty quick.

* Darcula and GruvBox
- allows adding header colors
- Switch containts correct color as well
# Conflicts:
#	app/src/main/res/layout/customize_app_drawer_fragment.xml
#	app/src/main/res/layout/options_fragment.xml
@TobiTenno TobiTenno merged commit 28de5e7 into jkuester:master Dec 22, 2023
@hayribakici hayribakici deleted the themes branch December 22, 2023 08:04
khwolf added a commit to khwolf/unlauncher that referenced this pull request Dec 22, 2023
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
Co-authored-by: Klaus-Hendrik Wolf <Klaus-Hendrik.Wolf@plri.de>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theming?
4 participants