forked from sduduzog/slim-launcher
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds new themes: Darcula and Gruvbox #138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Darcula and GruvBox
This comment was marked as resolved.
This comment was marked as resolved.
- allows adding header colors - Switch containts correct color as well
TobiTenno
requested changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome! if you could rebase, we'd be able to move it though pretty quick.
* Darcula and GruvBox
- allows adding header colors - Switch containts correct color as well
# Conflicts: # app/src/main/res/layout/customize_app_drawer_fragment.xml # app/src/main/res/layout/options_fragment.xml
TobiTenno
approved these changes
Dec 22, 2023
khwolf
added a commit
to khwolf/unlauncher
that referenced
this pull request
Dec 22, 2023
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com> Co-authored-by: Klaus-Hendrik Wolf <Klaus-Hendrik.Wolf@plri.de>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #32 and adds two more themes: Darcula (here called "Vlad") as addressed in #32 and gruvbox (here called "Groovy"). It also adds the
navigationbarColor
(not shown in the screenshots). It furthermor allows to have header text colors for distinguishing beetween headers and the contents of the screen. The header colors are not set in stone, however both of them are part of their respective color themes.Also this PR adapts the
textColor
of theSwitchCompat
button correctly."Vlad"

"Groovy"
