-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds search field options #143
Conversation
- adds better logic
This comment was marked as resolved.
This comment was marked as resolved.
- adds some translations
# Conflicts: # app/src/main/res/values-de/strings.xml # app/src/main/res/values/strings.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩 This is great! Thanks!
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
This comment was marked as resolved.
This comment was marked as resolved.
This is super cool ! when will this change be released on fdroid to use or how can I already use this , so excited about this change ! <3 I tried using this apk in the master release pipeline however I was not able to install this on my phone, |
if you're running the fdroid build right now, you can't update with the self-signed one from the repo build. you'd have to uninstall your current local copy before you install the self-signed github one. (this is standard android behavior, not something specific to unlauncher) |
There is not a hard date, but we are hoping to have a beta release released within days and a formal |
oh thank you so much I am not familiar with android apps signing process, after uninstalling the app I downloaded from fdroid I was able to install this apk which is self signed, thank you so much for explaining this. |
Fixes #62, fixes #43. This PR adds an additional option screen to hide and position the search field in the app drawer. Since the 'show keyboard' toggle is also part of this, it is grouped together with this new option (see screenshots). Once the 'Show search field' switch is turned off, the show keyboard option and positioning the search field are disabled.
On a technical level, I had to upgrade
protobuf
to (the current) version3.23
, since the current version had problems wish the optional property.I am also thinking to add a 'Reset to default' action for this screen. What do you think @jkuester ?