Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds search field options #143

Merged
merged 19 commits into from
Dec 21, 2023
Merged

Conversation

hayribakici
Copy link

@hayribakici hayribakici commented Jun 29, 2023

Fixes #62, fixes #43. This PR adds an additional option screen to hide and position the search field in the app drawer. Since the 'show keyboard' toggle is also part of this, it is grouped together with this new option (see screenshots). Once the 'Show search field' switch is turned off, the show keyboard option and positioning the search field are disabled.

On a technical level, I had to upgrade protobuf to (the current) version 3.23, since the current version had problems wish the optional property.

I am also thinking to add a 'Reset to default' action for this screen. What do you think @jkuester ?

@hayribakici hayribakici marked this pull request as draft July 16, 2023 13:57
@hayribakici

This comment was marked as resolved.

@hayribakici hayribakici marked this pull request as ready for review July 17, 2023 19:57
# Conflicts:
#	app/src/main/res/values-de/strings.xml
#	app/src/main/res/values/strings.xml
Copy link
Owner

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 This is great! Thanks!

@jkuester jkuester merged commit b87f65c into jkuester:master Dec 21, 2023
1 check passed
@hayribakici hayribakici deleted the search_options branch December 21, 2023 23:04
khwolf pushed a commit to khwolf/unlauncher that referenced this pull request Dec 22, 2023
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
khwolf pushed a commit to khwolf/unlauncher that referenced this pull request Dec 22, 2023
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
@hayribakici

This comment was marked as resolved.

@TobiTenno
Copy link
Collaborator

@jkuester #138 fixes the textColor of the SwitchCompat buttons. This should also be applied in the new screens here. Should a new PR be created?

go ahead and make a new one, you'll probably get it done before one of us would.

@neshant
Copy link

neshant commented Dec 31, 2023

This is super cool ! when will this change be released on fdroid to use or how can I already use this , so excited about this change ! <3

I tried using this apk in the master release pipeline however I was not able to install this on my phone,
https://github.com/jkuester/unlauncher/actions/runs/7364754669 I did not see anything significantly different between the Master and Release pipeline that will not allow me to install this .apk from master build. Please advise.

@TobiTenno
Copy link
Collaborator

if you're running the fdroid build right now, you can't update with the self-signed one from the repo build. you'd have to uninstall your current local copy before you install the self-signed github one. (this is standard android behavior, not something specific to unlauncher)

@jkuester
Copy link
Owner

when will this change be released on fdroid

There is not a hard date, but we are hoping to have a beta release released within days and a formal 2.1.0 release cut within a few weeks. Normally, these releases will show up on the F-Droid repo 2-5 days after we cut them here on GitHub.

@neshant
Copy link

neshant commented Jan 3, 2024

if you're running the fdroid build right now, you can't update with the self-signed one from the repo build. you'd have to uninstall your current local copy before you install the self-signed github one. (this is standard android behavior, not something specific to unlauncher)

oh thank you so much I am not familiar with android apps signing process, after uninstalling the app I downloaded from fdroid I was able to install this apk which is self signed, thank you so much for explaining this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide search field Search box below apps list
4 participants