Shows and hides keyboard when scrolling the app drawer #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiTenno
requested changes
Dec 21, 2023
|
This PR is now outdated. As mentionend in the description, therefore reverting to draft. I propably won't be able to continue/fix the issue, and I would be grateful, if someone would pick this up. |
|
we're still talking over this, i don't know if it's quite gonna fit, especially with the search moving to the bottom, optionally |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a UX enhancement when scrolling through the app drawer.
If the show keyboard option is set, it will minimize the keyboard once users start scrolling down the app drawer. Vice versa, it displays the keyboard when the user is scrolling up again.
Screen_recording_20231021_132138.webm
In order to be smooth, the
MainActivity'sandroid:windowSoftInputModehad to be set toadjustNothing. This however conflicts with PR #143 , since it would cover the search field if it set to the bottom of the screen. There are fixes for this as seen in an official android guide.