PR: Add a year range option to the weather normals viewer #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the possibility to define year limits when computing the normals from monthly values.
…arrange_meteoviewer # Conflicts: # gwhat/meteo/weather_viewer.py
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
The objective of this PR is to add the possibility to select the year range over which the normals are calculated.
Also, the year range is now plotted on the graph, below the x-axis. Before, it is was impossible by looking at the graph to know for what years the normals corresponded to.
Finally, in this PR we also fixed some aesthetic bugs with the data table.