Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Body MinLength is not working properly #17

Closed
gernd opened this issue Sep 26, 2016 · 3 comments
Closed

Body MinLength is not working properly #17

gernd opened this issue Sep 26, 2016 · 3 comments
Labels
bug User-facing bugs

Comments

@gernd
Copy link

gernd commented Sep 26, 2016 •
edited
Loading

I have configured body length in the following way:

[body-min-length]
min-length=5

When I test gitlint with a commit message that is exactly 5 characters, I get the following validation error:

3: B5 Body message is too short (5<5)

Shouldn't the commit be valid, if the body consists of exactly 5 characters?
@jorisroovers
Copy link
Owner

You're absolutely right. I just looked into this and noticed that there's actually multiple bugs in the code that enforces this rule. I'll be looking into this for the 0.8.0 release which I'm hoping to find time for in the next month or two.

@jorisroovers jorisroovers added the bug User-facing bugs label Sep 26, 2016
@jorisroovers
Copy link
Owner

Thanks again for submitting. This will go out with the 0.8.0 release which I'm planning to get out before the end of the year.

@gernd
Copy link
Author

gernd commented Dec 24, 2016

👍 thanks for fixing this and happy holidays

jorisroovers pushed a commit that referenced this issue Dec 30, 2016
@jroovers-cisco
0.8.0 Release
65840b7 
The 0.8.0 release is a significant release that has been in the works
for a long time. Special thanks to Claymore, gernd and ZhangYaxu for submitting
bug reports and pull requests.

- Full unicode support: you can now lint messages in any language! This
  fixes #16 and #18.
- User-defined rules: you can now define your own custom rules
  if you want to extend gitlint's functionality.
- Pypy2 support!
- Debug output improvements: Gitlint will now print your active
  configuration when using --debug
- The general.target option can now also be set via -c flags
  or a .gitlint file
- Bugfixes:
    - Various important fixes related to configuration precedence
    - #17: Body MinLength is not working properly.
      **Behavior Change**: Gitlint now always applies this rule, even if
      the body has just a single line of content.
      Also, gitlint now counts the body-length for the entire body, not
      just the length of the first line.
- Various documentation improvements
- Development:
    - Pylint compliance for all supported python versions
    - Updated dependencies to latest versions
    - Various run_tests.sh improvements for developer convenience
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug User-facing bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorisroovers @gernd