Support Unicode string in commit message #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this. We have a similar unicode support issue with #16. I'm going to look into this for the upcoming release which I've started working on. My goal is to get it out before the end of the year. |
jorisroovers
pushed a commit
that referenced
this pull request
Dec 30, 2016
The 0.8.0 release is a significant release that has been in the works for a long time. Special thanks to Claymore, gernd and ZhangYaxu for submitting bug reports and pull requests. - Full unicode support: you can now lint messages in any language! This fixes #16 and #18. - User-defined rules: you can now define your own custom rules if you want to extend gitlint's functionality. - Pypy2 support! - Debug output improvements: Gitlint will now print your active configuration when using --debug - The general.target option can now also be set via -c flags or a .gitlint file - Bugfixes: - Various important fixes related to configuration precedence - #17: Body MinLength is not working properly. **Behavior Change**: Gitlint now always applies this rule, even if the body has just a single line of content. Also, gitlint now counts the body-length for the entire body, not just the length of the first line. - Various documentation improvements - Development: - Pylint compliance for all supported python versions - Updated dependencies to latest versions - Various run_tests.sh improvements for developer convenience
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Unicode string in commit message.
Error info when commit message content Chinese.
Traceback (most recent call last):
File "/usr/bin/gitlint", line 9, in
load_entry_point('gitlint==0.8.0dev', 'console_scripts', 'gitlint')()
File "/usr/lib/python2.6/site-packages/click-6.6-py2.6.egg/click/core.py", line 716, in call
return self.main(*args, **kwargs)
File "/usr/lib/python2.6/site-packages/click-6.6-py2.6.egg/click/core.py", line 696, in main
rv = self.invoke(ctx)
File "/usr/lib/python2.6/site-packages/click-6.6-py2.6.egg/click/core.py", line 1037, in invoke
return Command.invoke(self, ctx)
File "/usr/lib/python2.6/site-packages/click-6.6-py2.6.egg/click/core.py", line 889, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python2.6/site-packages/click-6.6-py2.6.egg/click/core.py", line 534, in invoke
return callback(*args, **kwargs)
File "/usr/lib/python2.6/site-packages/click-6.6-py2.6.egg/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/usr/lib/python2.6/site-packages/gitlint-0.8.0dev-py2.6.egg/gitlint/cli.py", line 104, in cli
ctx.invoke(lint)
File "/usr/lib/python2.6/site-packages/click-6.6-py2.6.egg/click/core.py", line 534, in invoke
return callback(*args, **kwargs)
File "/usr/lib/python2.6/site-packages/click-6.6-py2.6.egg/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/usr/lib/python2.6/site-packages/gitlint-0.8.0dev-py2.6.egg/gitlint/cli.py", line 128, in lint
linter.print_violations(violations)
File "/usr/lib/python2.6/site-packages/gitlint-0.8.0dev-py2.6.egg/gitlint/lint.py", line 78, in print_violations
self.display.eee("{0}: {1} {2}: "{3}"".format(v.line_nr, v.rule_id, v.message, v.content), exact=True)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 5-6: ordinal not in range(128)