-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement GH actions #881
Implement GH actions #881
Conversation
For some reason, |
The tests that are breaking aren't actually testing fs-extra, they're testing Node itself. This diff would fix tests: diff --git a/lib/ensure/__tests__/symlink.test.js b/lib/ensure/__tests__/symlink.test.js
index 22a0043..477b084 100644
--- a/lib/ensure/__tests__/symlink.test.js
+++ b/lib/ensure/__tests__/symlink.test.js
@@ -352,24 +352,6 @@ describe('fse-ensure-symlink', () => {
})
}
- describe('fs.symlink()', () => {
- const fn = fs.symlink
- tests.forEach(test => {
- const args = test[0].slice(0)
- const nativeBehavior = test[1]
- // const newBehavior = test[2]
- if (nativeBehavior === 'file-success') fileSuccess(args, fn)
- if (nativeBehavior === 'file-broken') fileBroken(args, fn)
- if (nativeBehavior === 'file-error') fileError(args, fn)
- if (nativeBehavior === 'file-dest-exists') fileDestExists(args, fn)
- args.push('dir')
- if (nativeBehavior === 'dir-success') dirSuccess(args, fn)
- if (nativeBehavior === 'dir-broken') dirBroken(args, fn)
- if (nativeBehavior === 'dir-error') dirError(args, fn)
- if (nativeBehavior === 'dir-dest-exists') dirDestExists(args, fn)
- })
- })
-
describe('ensureSymlink()', () => {
const fn = ensureSymlink
tests.forEach(test => {
@@ -410,24 +392,6 @@ describe('fse-ensure-symlink', () => {
})
})
- describe('fs.symlinkSync()', () => {
- const fn = fs.symlinkSync
- tests.forEach(test => {
- const args = test[0].slice(0)
- const nativeBehavior = test[1]
- // const newBehavior = test[2]
- if (nativeBehavior === 'file-success') fileSuccessSync(args, fn)
- if (nativeBehavior === 'file-broken') fileBrokenSync(args, fn)
- if (nativeBehavior === 'file-error') fileErrorSync(args, fn)
- if (nativeBehavior === 'file-dest-exists') fileDestExistsSync(args, fn)
- args.push('dir')
- if (nativeBehavior === 'dir-success') dirSuccessSync(args, fn)
- if (nativeBehavior === 'dir-broken') dirBrokenSync(args, fn)
- if (nativeBehavior === 'dir-error') dirErrorSync(args, fn)
- if (nativeBehavior === 'dir-dest-exists') dirDestExistsSync(args, fn)
- })
- })
-
describe('ensureSymlinkSync()', () => {
const fn = ensureSymlinkSync
tests.forEach(test => { @manidlou @JPeer264 Thoughts here? Should we be testing Node's behavior here, or should we remove these tests? Should we get to the bottom of why it behaves differently here? |
I am usually a very curious type of person and want to know why something is failing (or working :) ). But actually this is not the job of |
93e1d3e
to
a7bb1fa
Compare
Removed the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.