Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BREAKING: Drop Node 10 support #893

Merged
merged 3 commits into from
Apr 30, 2021
Merged

BREAKING: Drop Node 10 support #893

merged 3 commits into from
Apr 30, 2021

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Apr 29, 2021

Not needed if we merge #881 and kill the old CI providers. Will need edits; still need engines bump.

@RyanZim RyanZim added this to the 10.0.0 milestone Apr 29, 2021
@RyanZim RyanZim requested a review from JPeer264 April 29, 2021 18:26
@RyanZim
Copy link
Collaborator Author

RyanZim commented Apr 29, 2021

As usual, AppVeyor is a sloth for supporting new Node.js versions; I'll have to drop Node 16 tests on Windows for the time being. Yet another reason to switch to GH Actions.

Copy link
Collaborator

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding, is there actually a reason why we don't test node v15 on AppVeyor?

@RyanZim
Copy link
Collaborator Author

RyanZim commented Apr 29, 2021

@JPeer264 AppVeyor's performance generally isn't great, so we've traditionally only tested LTS releases there, to make the build run faster. GH Actions fixes this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants