Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ENH]: Introduce get_template for getting templates #298

Merged
merged 10 commits into from
Feb 9, 2024
Merged

Conversation

synchon
Copy link
Member

@synchon synchon commented Jan 31, 2024

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR introduces a new function junifer.data.get_template() to get template space images via templateflow, tailored to a target data.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4397f3f) 89.16% compared to head (1d5d635) 89.15%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   89.16%   89.15%   -0.01%     
==========================================
  Files         101      101              
  Lines        4466     4483      +17     
  Branches      854      856       +2     
==========================================
+ Hits         3982     3997      +15     
- Misses        346      348       +2     
  Partials      138      138              
Flag Coverage Δ
junifer 89.15% <89.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/data/__init__.py 100.00% <100.00%> (ø)
junifer/data/utils.py 100.00% <ø> (ø)
junifer/data/template_spaces.py 90.47% <88.88%> (-9.53%) ⬇️

@synchon
Copy link
Member Author

synchon commented Jan 31, 2024

Should be merged after #297

@synchon synchon added the enhancement New feature or request label Jan 31, 2024
Copy link

github-actions bot commented Jan 31, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-09 11:00 UTC

@synchon synchon requested a review from fraimondo February 1, 2024 08:45
@synchon synchon linked an issue Feb 2, 2024 that may be closed by this pull request
1 task
@synchon synchon added this to the 0.0.4 (alpha 3) milestone Feb 8, 2024
@synchon synchon requested a review from fraimondo February 9, 2024 09:33
@synchon synchon merged commit 03d5e91 into main Feb 9, 2024
21 of 24 checks passed
@synchon synchon deleted the feat/get-template branch February 9, 2024 10:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH]: Support for template spaces from templateflow
2 participants