[ENH]: Add support for on-the-fly template space transformation #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
============================================
+ Coverage 88.15% 100.00% +11.84%
============================================
Files 111 1 -110
Lines 4820 1 -4819
Branches 957 0 -957
============================================
- Hits 4249 1 -4248
+ Misses 417 0 -417
+ Partials 154 0 -154
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Needs to go after #298 |
fraimondo
previously approved these changes
Feb 14, 2024
synchon
force-pushed
the
feat/multi-mni-support
branch
from
51c0d78 to
c11a7b3
Compare
|
synchon
force-pushed
the
feat/multi-mni-support
branch
from
1745d0f to
2465877
Compare
synchon
added
the
coordinate
synchon
added
parcellation
synchon
force-pushed
the
feat/multi-mni-support
branch
from
aa60ee7 to
3089a7a
Compare
synchon
force-pushed
the
feat/multi-mni-support
branch
3 times, most recently
from
1720b57 to
5211abf
Compare
synchon
force-pushed
the
feat/multi-mni-support
branch
3 times, most recently
from
fce0120 to
2b4e463
Compare
|
@fraimondo Can we merge this? |
fraimondo
reviewed
Mar 27, 2024
|
@synchon Just that one question. |
synchon
force-pushed
the
feat/multi-mni-support
branch
from
293137b to
e8f8ede
Compare
…ing via templateflow
synchon
force-pushed
the
feat/multi-mni-support
branch
from
a6723d1 to
78d63d6
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for on-the-fly template space transformation in
junifer.data.get_parcellation()andjunifer.data.get_mask()enabling merging of multi-space parcellation and mask. The target space is set as per the datagrabber's specification and all of the other assets are transformed to it and then applied.