Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removed duplicate check on jwks_uri and only check if jwks_uri exists when needed #373

Merged

Conversation

ricklambrechts
Copy link
Contributor

@ricklambrechts ricklambrechts commented May 17, 2023

Fixes #182

List of common tasks a pull request require complete

  • Changelog entry is added or the pull request don't alter library's functionality

@ricklambrechts ricklambrechts force-pushed the remove-duplicate-jwks-uri-check branch from ce52df0 to 6288d59 Compare May 17, 2023 16:29
@ricklambrechts ricklambrechts force-pushed the remove-duplicate-jwks-uri-check branch from 659a812 to 8cfe400 Compare April 23, 2024 08:33
@ricklambrechts ricklambrechts changed the title Removed duplicate check on jwks_uri Removed duplicate check on jwks_uri and only check if jwks_uri exists when needed Apr 23, 2024
@ricklambrechts
Copy link
Contributor Author

@DeepDiver1975 I have updated this PR. Can you check it?

@DeepDiver1975 DeepDiver1975 merged commit 1a468a4 into jumbojett:master Apr 23, 2024
9 checks passed
@ricklambrechts ricklambrechts deleted the remove-duplicate-jwks-uri-check branch April 23, 2024 11:47
Magentron added a commit to Magentron/OpenID-Connect-PHP that referenced this pull request May 22, 2024
* upstream/master:
  fix: Removed duplicate check on jwks_uri and only check if jwks_uri exists when needed (jumbojett#373)
  fix: Check if subject is equal to subject of id token when verifying JWT claims (jumbojett#406)
  fix: Cast SERVER_PORT to integer (jumbojett#404)
  chore(deps): bump actions/cache from 3 to 4 (jumbojett#417)
  chore(deps): bump actions/checkout from 2 to 4 (jumbojett#416)
  docs: Update README.md to correct addScope parameter type in 1.0.0 (jumbojett#405)
  chore: Update ci to support php 8.3 and add dependabot (jumbojett#407)
  release: 1.0.0 (jumbojett#402)
  Set the User-Agent regardless of GET or POST (jumbojett#382)
  fix: Update well known config value function response types (jumbojett#376)
  feat: set useragent (jumbojett#370)
  feat: php7.0 minimum requirement (jumbojett#327)

# Conflicts:
#	CHANGELOG.md
Magentron added a commit to Magentron/OpenID-Connect-PHP that referenced this pull request May 22, 2024
…est-token

* master:
  fix: Removed duplicate check on jwks_uri and only check if jwks_uri exists when needed (jumbojett#373)
  fix: Check if subject is equal to subject of id token when verifying JWT claims (jumbojett#406)
  fix: Cast SERVER_PORT to integer (jumbojett#404)
  chore(deps): bump actions/cache from 3 to 4 (jumbojett#417)
  chore(deps): bump actions/checkout from 2 to 4 (jumbojett#416)
  docs: Update README.md to correct addScope parameter type in 1.0.0 (jumbojett#405)
  chore: Update ci to support php 8.3 and add dependabot (jumbojett#407)
  release: 1.0.0 (jumbojett#402)
  Set the User-Agent regardless of GET or POST (jumbojett#382)
  fix: Update well known config value function response types (jumbojett#376)
  feat: set useragent (jumbojett#370)
  feat: php7.0 minimum requirement (jumbojett#327)
  updated composer.json added replace, updated README.md added notification about project forked from

# Conflicts:
#	CHANGELOG.md
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jwks_uri shouldn't be a requirement for checking signatures
2 participants