Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cast SERVER_PORT to integer #404

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

timsmid
Copy link
Contributor

@timsmid timsmid commented Dec 15, 2023

Resolves issue #403.

List of common tasks a pull request require complete

  • Changelog entry is added or the pull request don't alter library's functionality

@bison92
Copy link

bison92 commented Mar 8, 2024

Hi @jumbojett please merge this!

@Webbeh
Copy link

Webbeh commented Mar 15, 2024

Bump

This fix works for me as well. It is required for NGINX which sends the SERVER_PORT as string and not int.

@DeepDiver1975
Copy link
Collaborator

Can you rebase please? THX

@timsmid
Copy link
Contributor Author

timsmid commented Apr 22, 2024

@DeepDiver1975 Done!

@DeepDiver1975 DeepDiver1975 merged commit e31ec33 into jumbojett:master Apr 22, 2024
9 checks passed
Magentron added a commit to Magentron/OpenID-Connect-PHP that referenced this pull request May 22, 2024
* upstream/master:
  fix: Removed duplicate check on jwks_uri and only check if jwks_uri exists when needed (jumbojett#373)
  fix: Check if subject is equal to subject of id token when verifying JWT claims (jumbojett#406)
  fix: Cast SERVER_PORT to integer (jumbojett#404)
  chore(deps): bump actions/cache from 3 to 4 (jumbojett#417)
  chore(deps): bump actions/checkout from 2 to 4 (jumbojett#416)
  docs: Update README.md to correct addScope parameter type in 1.0.0 (jumbojett#405)
  chore: Update ci to support php 8.3 and add dependabot (jumbojett#407)
  release: 1.0.0 (jumbojett#402)
  Set the User-Agent regardless of GET or POST (jumbojett#382)
  fix: Update well known config value function response types (jumbojett#376)
  feat: set useragent (jumbojett#370)
  feat: php7.0 minimum requirement (jumbojett#327)

# Conflicts:
#	CHANGELOG.md
Magentron added a commit to Magentron/OpenID-Connect-PHP that referenced this pull request May 22, 2024
…est-token

* master:
  fix: Removed duplicate check on jwks_uri and only check if jwks_uri exists when needed (jumbojett#373)
  fix: Check if subject is equal to subject of id token when verifying JWT claims (jumbojett#406)
  fix: Cast SERVER_PORT to integer (jumbojett#404)
  chore(deps): bump actions/cache from 3 to 4 (jumbojett#417)
  chore(deps): bump actions/checkout from 2 to 4 (jumbojett#416)
  docs: Update README.md to correct addScope parameter type in 1.0.0 (jumbojett#405)
  chore: Update ci to support php 8.3 and add dependabot (jumbojett#407)
  release: 1.0.0 (jumbojett#402)
  Set the User-Agent regardless of GET or POST (jumbojett#382)
  fix: Update well known config value function response types (jumbojett#376)
  feat: set useragent (jumbojett#370)
  feat: php7.0 minimum requirement (jumbojett#327)
  updated composer.json added replace, updated README.md added notification about project forked from

# Conflicts:
#	CHANGELOG.md
@nobleclem
Copy link

v1.0.1 seems to be missing this update. Looks like the commit (1e85443) from on 9/5/2024 for #427 reverted the change.

DeepDiver1975 added a commit that referenced this pull request Sep 13, 2024
DeepDiver1975 added a commit that referenced this pull request Sep 13, 2024
BSnelling pushed a commit to HDRUK/OpenID-Connect-PHP that referenced this pull request Sep 18, 2024
Magentron added a commit to Magentron/OpenID-Connect-PHP that referenced this pull request Nov 7, 2024
* upstream/master:
  fix: protected responseContentType to allow overloading of fetchUrl function (jumbojett#446)
  test: unit tests for verifyJWTClaims and different aud claims (jumbojett#443)
  Fix TypeError in `verifyJWTClaims` (jumbojett#442)
  release: v1.0.2 (jumbojett#439)
  test: add unit test for SERVER_PORT type cast (jumbojett#438)
  fix: bring back jumbojett#404 (jumbojett#437)
  release: v1.0.1 (jumbojett#432)
  fix: protected $responseCode to allow proper overloading of fetchURL() (jumbojett#433)
  chore(deps-dev): update yoast/phpunit-polyfills requirement from ^1.0 to ^2.0 (jumbojett#430)
  chore(deps): update phpseclib/phpseclib requirement from ~3.0 to ^3.0.7
  ci: run GitHub workflows on pull requests and pushes to master (jumbojett#431)
  chore: enable dependabot for composer (jumbojett#429)
  fix: handle JWT decode of non JWT tokens (jumbojett#428)
  fix: method signatures after 1.0 release (jumbojett#427)
Magentron added a commit to Magentron/OpenID-Connect-PHP that referenced this pull request Nov 7, 2024
…est-token

* master:
  fix: protected responseContentType to allow overloading of fetchUrl function (jumbojett#446)
  test: unit tests for verifyJWTClaims and different aud claims (jumbojett#443)
  Fix TypeError in `verifyJWTClaims` (jumbojett#442)
  release: v1.0.2 (jumbojett#439)
  test: add unit test for SERVER_PORT type cast (jumbojett#438)
  fix: bring back jumbojett#404 (jumbojett#437)
  release: v1.0.1 (jumbojett#432)
  fix: protected $responseCode to allow proper overloading of fetchURL() (jumbojett#433)
  chore(deps-dev): update yoast/phpunit-polyfills requirement from ^1.0 to ^2.0 (jumbojett#430)
  chore(deps): update phpseclib/phpseclib requirement from ~3.0 to ^3.0.7
  ci: run GitHub workflows on pull requests and pushes to master (jumbojett#431)
  chore: enable dependabot for composer (jumbojett#429)
  fix: handle JWT decode of non JWT tokens (jumbojett#428)
  fix: method signatures after 1.0 release (jumbojett#427)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants