Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

include metadata when copying a cell #2349

Merged
merged 1 commit into from
Apr 10, 2017
Merged

include metadata when copying a cell #2349

merged 1 commit into from
Apr 10, 2017

Conversation

parmentelat
Copy link
Contributor

@parmentelat parmentelat commented Mar 29, 2017

Following up on #2273, I came up with this proposal.

I was not able to test this though, because I do not know how to try out my modified code in a running jupyter

Also I chose to copy the original cell's metadata using json, because I believe a copy is required in this context, but there might be better ways to do that copy

This is my first pull request ever and I am not too comfy in javascript either..

closes #2273

@gnestor gnestor added this to the 5.1 milestone Mar 29, 2017
I was not able to test this though
preserves initial strategy that uses original cell as cell B
so as to preserve selection
@minrk minrk changed the title an early attempt to fix #2273 include metadata when copying a cell Apr 10, 2017
@minrk
Copy link
Member

minrk commented Apr 10, 2017

Thanks, this should work!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

splitting a slide cell results in one non-slide cell and one slide cell
3 participants