Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add 5.1.0 to changelog #2723

Merged
merged 3 commits into from
Aug 4, 2017
Merged

Add 5.1.0 to changelog #2723

merged 3 commits into from
Aug 4, 2017

Conversation

gnestor
Copy link
Contributor

@gnestor gnestor commented Aug 3, 2017

Preview:

See the 5.1 milestone on GitHub for a complete list of issues and pull requests involved in this release.

@gnestor gnestor added this to the 5.1 milestone Aug 3, 2017
@gnestor gnestor requested a review from takluyver August 3, 2017 19:58
Copy link
Member

@takluyver takluyver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this - there are a few bits of wording that I think could be clearer, but otherwise +1

- Include metadata when copying a cell (:ghpull:`2349`).
- Stop notebooks from command line (:ghpull:`2388`).
- Improve "View" and "Edit" file handling in dashboard (:ghpull:`2449`) and (:ghpull:`2402`).
- Load custom.js before ``app_initialized.NotebookApp`` is triggered (:ghpull:`2710`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is misleading. We haven't changed the order of loading things - instead we added a promise as a new mechanism to run code after the application is initialized.

- Add session-specific favicons (notebook, terminal, file) (:ghpull:`2452`).
- Add /api/shutdown handler (:ghpull:`2507`).
- Include metadata when copying a cell (:ghpull:`2349`).
- Stop notebooks from command line (:ghpull:`2388`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's clearer to say 'notebook servers'.

- Preliminary i18n implementation (:ghpull:`2140`).
- Expose URL with auth token in notebook UI (:ghpull:`2666`).
- Fix search background style (:ghpull:`2387`).
- List running notebooks with ``--allow-root`` (:ghpull:`2421`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the point of this PR is that you can list running notebook servers without needing --allow-root, whereas previously it was doing that check when it wasn't necessary.

- Include metadata when copying a cell (:ghpull:`2349`).
- Stop notebook server from command line (:ghpull:`2388`).
- Improve "View" and "Edit" file handling in dashboard (:ghpull:`2449`) and (:ghpull:`2402`).
- Provide a Promise implementation for ``app_initialized.NotebookApp`` event (:ghpull:`2710`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, but still not very clear. How about "Provide a promise to replace use of the app_initialized.NotebookApp event"?

@takluyver takluyver merged commit fcc5b0f into jupyter:master Aug 4, 2017
@takluyver
Copy link
Member

Thanks

@gnestor gnestor deleted the 5.1 branch August 4, 2017 12:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants