Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(cypress): add mandates and refunds variation cases #5513

Merged
merged 9 commits into from
Aug 7, 2024
Merged

feat(cypress): add mandates and refunds variation cases #5513

merged 9 commits into from
Aug 7, 2024

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Aug 2, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR:

  • Fixes inconsistencies with respect to naming in configs (bank redirects) -- Make all object names follow PascalCase naming convention
  • Add mandate validation
  • Variation tests:
    • Refunds exceed captured amount
    • Recurring mandate with greater mandate amount
    • Refund unsuccessful amount
    • 3DS with greater capture
    • Void successful payment
  • Add basic structural support for responseCustom[this provides us the ability to define multiple Responses (limited to 2) for a single request]
    • This opens up possibility for us to handle multiple responses that we receive from connector's end
    • For example, in Adyen when capture_method is automatic, payment status goes to succeeded state and when capture_method is manual, payment status goes to processing state

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Why?

How did you test it?

Tested against Stripe:

image

Iatapay, which is more error prone, just works:

image

Checklist

  • I formatted the code prettier . --write
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 2, 2024
@pixincreate pixincreate added this to the July 2024 Release milestone Aug 2, 2024
@pixincreate pixincreate self-assigned this Aug 2, 2024
@pixincreate pixincreate requested review from a team as code owners August 2, 2024 09:29
@pixincreate
chore: 3ds it is
44711dd
@pixincreate
chore: get it right
1b2a5fd
@pixincreate
enhancement: add some more tests
e21ff8b
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into variation-c…
3fa4554 
…ypress-x2

* 'main' of github.com:juspay/hyperswitch:
  refactor(cypress): pass `connector_type` externally (#5522)
  refactor(router): refactor merchant_connector update v2 flow (#5484)
  feat(router): add accept language header middleware  (#5500)
  chore(version): 2024.08.05.0
  chore(postman): update Postman collection files
  fix(pm_auth): Added mca status check in pml (#5421)
  refactor(payment_methods): List the Payment Methods for Merchant , based on the connector  type (#4909)
  fix(router): [Iatapay] make error status and error message optional (#5382)
  chore(version): 2024.08.02.0
  feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497)
  feat(auth): Add `profile_id` in `AuthenticationData` (#5492)
  feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498)
  refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462)
  fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501)
  refactor(role): determine level of role entity (#5488)
@Gnanasundari24
Copy link
Contributor

@pixincreate Can you add the tescase result for adyen and paypal as you have introduced custom response

@pixincreate
Copy link
Member Author

pixincreate commented Aug 7, 2024 •
edited
Loading

@pixincreate Can you add the tescase result for adyen and paypal as you have introduced custom response

As you can see in the changes introduced to Adyen configs and commons in this PR, I've only added the basic support for responseCustom and have not added any tests or fixes for respective connectors mentioned. That can be taken up as a separate PR.

Edit: Updated PR description for more clarity.

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 29c5f8a Aug 7, 2024
22 checks passed
@Gnanasundari24 Gnanasundari24 deleted the variation-cypress-x2 branch August 7, 2024 09:02
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 7, 2024
pixincreate added a commit that referenced this pull request Aug 7, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into configurabl…
24db770 
…e-connector-label-cypress

* 'main' of github.com:juspay/hyperswitch:
  feat(core): add support for payment links localization (#5530)
  refactor(router): refactor `merchant_connector_account` retrieve and delete v2 apis (#5528)
  feat(cypress): add core flow tests (#5546)
  feat(cypress): add mandates and refunds variation cases (#5513)
  feat(cypress): add configs for not overriding screenshots (#5524)
  refactor(business_profile): use concrete types for JSON fields (#5531)
  feat(customer_v2):  add customer create v2 endpoint  (#5444)
  refactor(connector): added amount conversion framework for Mifinity (#5460)
  refactor(connector): added amount conversion framework for Boku (#5459)
  chore(version): 2024.08.07.0
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@likhinbopanna likhinbopanna likhinbopanna approved these changes

@Gnanasundari24 Gnanasundari24 Gnanasundari24 approved these changes

@Sakilmostak Sakilmostak Awaiting requested review from Sakilmostak

Assignees

@pixincreate pixincreate

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Milestone
August 2024 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@pixincreate @Gnanasundari24 @likhinbopanna @SanchithHegde