Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(connector): [NEXIXPAY] Add template code #5684

Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat(connector): [NEXIXPAY] Add template code #5684

merged 5 commits into from
Aug 28, 2024

Conversation

mrudulvajpayee4935
Copy link
Contributor

@mrudulvajpayee4935 mrudulvajpayee4935 commented Aug 23, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Template code added for new connector Nexi-Xpay

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@mrudulvajpayee4935 mrudulvajpayee4935 requested review from a team as code owners August 23, 2024 10:56
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Aug 23, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 12 of 25 files.

Overall, the semantic diff is 8% smaller than the GitHub diff.

File Information
Filename Status
❔ scripts/add_connector.sh Unsupported file format
❔ loadtest/config/development.toml Unsupported file format
✔️ crates/test_utils/src/connector_auth.rs Analyzed
✔️ crates/router/tests/connectors/main.rs Analyzed
❔ crates/router/tests/connectors/nexixpay.rs Unsupported file format
❔ crates/router/tests/connectors/sample_auth.toml Unsupported file format
✔️ crates/router/src/connector.rs 78.27% smaller
✔️ crates/router/src/types/api.rs Analyzed
✔️ crates/router/src/types/transformers.rs Analyzed
✔️ crates/router/src/core/payments/connector_integration_v2_impls.rs 4.61% smaller
❔ crates/router/src/core/payments/flows.rs Unsupported file format
✔️ crates/hyperswitch_interfaces/src/configs.rs Analyzed
✔️ crates/hyperswitch_connectors/src/connectors.rs 1.1% smaller
✔️ crates/hyperswitch_connectors/src/default_implementations.rs 6.95% smaller
✔️ crates/hyperswitch_connectors/src/default_implementations_v2.rs 6.86% smaller
❔ crates/hyperswitch_connectors/src/connectors/nexixpay.rs Unsupported file format
❔ crates/hyperswitch_connectors/src/connectors/nexixpay/transformers.rs Unsupported file format
✔️ crates/common_enums/src/enums.rs Analyzed
✔️ crates/api_models/src/enums.rs Analyzed
❔ config/config.example.toml Unsupported file format
❔ config/development.toml Unsupported file format
❔ config/docker_compose.toml Unsupported file format
❔ config/deployments/integration_test.toml Unsupported file format
❔ config/deployments/production.toml Unsupported file format
❔ config/deployments/sandbox.toml Unsupported file format

@mrudulvajpayee4935 mrudulvajpayee4935 linked an issue Aug 26, 2024 that may be closed by this pull request
[FEATURE] ADD NEXIXPAY CONNECTOR #5693
Closed
2 tasks
AkshayaFoiger
AkshayaFoiger reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@AkshayaFoiger AkshayaFoiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the connector name in alphabetic order, wherever necessary

crates/router/tests/connectors/sample_auth.toml Outdated
@@ -261,6 +261,9 @@ api_key="API Key"
[fiservemea]
api_key="API Key"

[nexixpay]
api_key=API Key"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
api_key=API Key"
api_key="API Key"

AkshayaFoiger
AkshayaFoiger previously approved these changes Aug 26, 2024
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Aug 26, 2024
View reviewed changes
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 303684d Aug 28, 2024
14 checks passed
@Gnanasundari24 Gnanasundari24 deleted the nexixpay-template branch August 28, 2024 08:01
pixincreate added a commit that referenced this pull request Aug 28, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into add-auto-retry
b8c2faf 
* 'main' of github.com:juspay/hyperswitch:
  feat(connector): [FISERVEMEA] Integrate cards (#5672)
  ci(cypress): Add routing testcases (#5571)
  fix(router): skip external three_ds flow for recurring payments (#5730)
  refactor(customer_v2): fixed customer_v2 create panic issue (#5699)
  feat(user_roles): support switch for new hierarchy (#5692)
  refactor(router): add domain type for merchant_connector_account id (#5685)
  refactor(cypress_tests): handle api keys check in api key list call (#5719)
  feat(connector): [NEXIXPAY] Add template code (#5684)
  refactor(connector): [itau] refactor error reason and code mapping for itau (#5718)
  fix(core): fix merchant connector account create for v2  (#5716)
  chore(version): 2024.08.28.0
  fix(routing): fix routing routes to deserialise correctly (#5724)
  feat(euclid): add a new variant in payment type i.e ppt_mandate (#5681)
  feat(core): Add mTLS certificates for each request (#5636)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@AkshayaFoiger AkshayaFoiger AkshayaFoiger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] ADD NEXIXPAY CONNECTOR
6 participants
@mrudulvajpayee4935 @SanchithHegde @deepanshu-iiitu @sai-harsha-vardhan @AkshayaFoiger @Gnanasundari24