refactor(router): add domain type for merchant_connector_account id #5685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
the
M-database-changes
hyperswitch-bot
bot
removed
the
M-database-changes
hyperswitch-bot
bot
added
the
M-api-contract-changes
hyperswitch-bot
bot
removed
the
M-api-contract-changes
sai-harsha-vardhan
requested review from
Narayanbhat166,
jarnura and
SanchithHegde
jarnura
requested changes
Aug 27, 2024
crates/api_models/src/admin.rs
Outdated
| #[schema(example = "mca_5apGeP94tMts6rg3U3kR")] | ||
| pub merchant_connector_id: Option<String>, | ||
| #[schema(example = "mca_5apGeP94tMts6rg3U3kR", value_type = Option<String>)] | ||
| pub merchant_connector_id: Option<id_type::MerchantConnectorAccountId>, |
hyperswitch-bot
bot
added
the
M-api-contract-changes
jarnura
previously approved these changes
Aug 27, 2024
…m:juspay/hyperswitch into add-domain-type-for-merchant-connector-id
ThisIsMani
previously approved these changes
Aug 27, 2024
prajjwalkumar17
previously approved these changes
Aug 27, 2024
sai-harsha-vardhan
dismissed stale reviews from prajjwalkumar17 and ThisIsMani
via
68b6dc0
sai-harsha-vardhan
requested review from
SanchithHegde,
prajjwalkumar17 and
ThisIsMani
prajjwalkumar17
approved these changes
Aug 27, 2024
SanchithHegde
approved these changes
Aug 27, 2024
ThisIsMani
approved these changes
Aug 27, 2024
jarnura
approved these changes
Aug 28, 2024
pixincreate
added a commit
that referenced
this pull request
Aug 28, 2024
* 'main' of github.com:juspay/hyperswitch: feat(connector): [FISERVEMEA] Integrate cards (#5672) ci(cypress): Add routing testcases (#5571) fix(router): skip external three_ds flow for recurring payments (#5730) refactor(customer_v2): fixed customer_v2 create panic issue (#5699) feat(user_roles): support switch for new hierarchy (#5692) refactor(router): add domain type for merchant_connector_account id (#5685) refactor(cypress_tests): handle api keys check in api key list call (#5719) feat(connector): [NEXIXPAY] Add template code (#5684) refactor(connector): [itau] refactor error reason and code mapping for itau (#5718) fix(core): fix merchant connector account create for v2 (#5716) chore(version): 2024.08.28.0 fix(routing): fix routing routes to deserialise correctly (#5724) feat(euclid): add a new variant in payment type i.e ppt_mandate (#5681) feat(core): Add mTLS certificates for each request (#5636)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add domain type for merchant_connector_account id
Additional Changes
Motivation and Context
How did you test it?
Tested Manually
Checklist
cargo +nightly fmt --allcargo clippy