Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: populate payment method details in payments response #5790

Merged

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Sep 4, 2024

(cherry picked from commit c84af20)

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Reverts the changes in merge commit of PR #5661 for creating a hotfix

(#5785)

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m self-assigned this Sep 4, 2024
@kashif-m kashif-m requested review from a team as code owners September 4, 2024 10:07
Copy link

semanticdiff-com bot commented Sep 4, 2024

Review changes with SemanticDiff.

Analyzed 8 of 10 files.

Overall, the semantic diff is 5% smaller than the GitHub diff.

Filename Status
✔️ crates/router/src/core/payments/helpers.rs 44.98% smaller
✔️ crates/openapi/src/openapi.rs 1.85% smaller
✔️ crates/openapi/src/openapi_v2.rs 1.85% smaller
✔️ crates/masking/src/lib.rs Analyzed
crates/masking/src/masked_string.rs Unsupported file format
✔️ crates/hyperswitch_domain_models/src/payment_method_data.rs 0.99% smaller
✔️ crates/api_models/src/payments.rs 49.42% smaller
crates/api_models/src/payments/additional_info.rs Unsupported file format
✔️ api-reference-v2/openapi_spec.json Analyzed
✔️ api-reference/openapi_spec.json Analyzed

@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Sep 4, 2024
@kashif-m kashif-m changed the base branch from main to hotfix-2024.08.30.0 September 4, 2024 10:10
@Sarthak1799
Copy link
Contributor

Checks are failing @kashif-m

@likhinbopanna likhinbopanna changed the title feat(revert): populate payment method details in payments response feat: populate payment method details in payments response Sep 4, 2024
@likhinbopanna likhinbopanna merged commit 438c124 into hotfix-2024.08.30.0 Sep 4, 2024
23 of 28 checks passed
@likhinbopanna likhinbopanna deleted the payments-webhooks-response-revert-hotfix branch September 4, 2024 15:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Payments and it's webhook response to contain non-card payment method details
6 participants