Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: populate payment method details in payments response #5661

Merged
merged 10 commits into from
Aug 26, 2024
Merged

feat: populate payment method details in payments response #5661

merged 10 commits into from
Aug 26, 2024

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Aug 21, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Described in #5652

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Helps in identification of payment method details which were used for the payment. This is returned in payment retrieve and payment webhooks.

How did you test it?

1. Complete and retrieve a gift card payment 
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_JCI3dRg06RjMyOrBDO81euxfOykGXlA9zgW4Cf2iXGy2xwexsY6GOSH5sI41GugN' \
--data-raw '{
    "amount": 1100,
    "currency": "EUR",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "amount_to_capture": 1100,
    "customer_id": "StripeCustomer",
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://duck.com",
    "payment_method": "gift_card",
    "payment_method_type": "givex",
    "payment_method_data": {
        "gift_card": {
            "givex": {
                "number": "6364530000000000",
                "cvc": "122222"
            }
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "PiX"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "PiX"
        }
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
}'
2. Retrieve and verify in webhooks response as well 
curl --location 'http://localhost:8080/payments/pay_oRcnlCyFw1WVMQkg4fZq?force_sync=true' \
    --header 'Accept: application/json' \
    --header 'api-key: dev_p9yMRqUZKavXldvbcW8w0GfzR1ynBE2ORUu4FPY3rU82G8OFBx2XOq6ty71UrBIN'

Response

    {
        "payment_id": "pay_oRcnlCyFw1WVMQkg4fZq",
        "merchant_id": "postman_merchant_GHAction_011d2d37-e13d-4b83-a896-816c4d097d18",
        "status": "succeeded",
        "amount": 1100,
        "net_amount": 1100,
        "amount_capturable": 0,
        "amount_received": 1100,
        "connector": "adyen",
        "client_secret": "pay_oRcnlCyFw1WVMQkg4fZq_secret_NEFqOOcfDZyWNd5BXExn",
        "created": "2024-08-26T06:08:24.376Z",
        "currency": "EUR",
        "customer_id": "StripeCustomer",
        "customer": {
            "id": "StripeCustomer",
            "name": "John Doe",
            "email": "guest@example.com",
            "phone": "999999999",
            "phone_country_code": "+65"
        },
        "description": "Its my first payment request",
        "refunds": null,
        "disputes": null,
        "mandate_id": null,
        "mandate_data": null,
        "setup_future_usage": null,
        "off_session": null,
        "capture_on": null,
        "capture_method": "automatic",
        "payment_method": "gift_card",
        "payment_method_data": {
            "gift_card": {
                "givex": {
                    "last4": "0000"
                }
            },
            "billing": null
        },
        "payment_token": null,
        "shipping": {
            "address": {
                "city": "San Fransico",
                "country": "US",
                "line1": "1467",
                "line2": "Harrison Street",
                "line3": "Harrison Street",
                "zip": "94122",
                "state": "California",
                "first_name": "PiX",
                "last_name": null
            },
            "phone": null,
            "email": null
        },
        "billing": {
            "address": {
                "city": "San Fransico",
                "country": "US",
                "line1": "1467",
                "line2": "Harrison Street",
                "line3": "Harrison Street",
                "zip": "94122",
                "state": "California",
                "first_name": "PiX",
                "last_name": null
            },
            "phone": null,
            "email": null
        },
        "order_details": null,
        "email": "guest@example.com",
        "name": "John Doe",
        "phone": "999999999",
        "return_url": "https://duck.com/",
        "authentication_type": "no_three_ds",
        "statement_descriptor_name": "joseph",
        "statement_descriptor_suffix": "JS",
        "next_action": null,
        "cancellation_reason": null,
        "error_code": null,
        "error_message": null,
        "unified_code": null,
        "unified_message": null,
        "payment_experience": null,
        "payment_method_type": "givex",
        "connector_label": null,
        "business_country": null,
        "business_label": "default",
        "business_sub_label": null,
        "allowed_payment_method_types": null,
        "ephemeral_key": null,
        "manual_retry_allowed": false,
        "connector_transaction_id": "F7S9XBDCFJK94875",
        "frm_message": null,
        "metadata": {
            "udf1": "value1",
            "login_date": "2019-09-10T10:11:12Z",
            "new_customer": "true"
        },
        "connector_metadata": null,
        "feature_metadata": null,
        "reference_id": "pay_oRcnlCyFw1WVMQkg4fZq_1",
        "payment_link": null,
        "profile_id": "pro_gsiLSYq37GwBEhz0ev26",
        "surcharge_details": null,
        "attempt_count": 1,
        "merchant_decision": null,
        "merchant_connector_id": "mca_xR9f8EBOdN45KgAkTCLx",
        "incremental_authorization_allowed": null,
        "authorization_count": null,
        "incremental_authorizations": null,
        "external_authentication_details": null,
        "external_3ds_authentication_attempted": false,
        "expires_on": "2024-08-26T06:23:24.376Z",
        "fingerprint": null,
        "browser_info": null,
        "payment_method_id": null,
        "payment_method_status": null,
        "updated": "2024-08-26T06:08:25.813Z",
        "charges": null,
        "frm_metadata": null,
        "merchant_order_reference_id": null
    }

image
image

3. Bank Debit - ACH 
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_JCI3dRg06RjMyOrBDO81euxfOykGXlA9zgW4Cf2iXGy2xwexsY6GOSH5sI41GugN' \
--data-raw '{
    "amount": 10000,
    "currency": "USD",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "StripeCustomer",
    "email": "abcdef123@gmail.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "authentication_type": "three_ds",
    "return_url": "https://duck.com",
    "setup_future_usage": "on_session",
    "customer_acceptance": {
        "acceptance_type": "offline",
        "accepted_at": "1963-05-03T04:07:52.723Z",
        "online": {
            "ip_address": "127.0.0.1",
            "user_agent": "amet irure esse"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US"
        }
    },
    "browser_info": {
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "127.0.0.1"
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "John",
            "last_name": "Doe"
        }
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "payment_method": "bank_debit",
    "payment_method_type": "ach",
    "payment_method_data": {
        "bank_debit": {
            "ach_bank_debit": {
                "account_number": "40308669",
                "routing_number": "121000358",
                "sort_code": "560036",
                "shopper_email": "example@gmail.com",
                "card_holder_name": "joseph Doe",
                "bank_account_holder_name": "David Archer",
                "billing_details": {
                    "houseNumberOrName": "50",
                    "street": "Test Street",
                    "city": "Amsterdam",
                    "stateOrProvince": "NY",
                    "postalCode": "12010",
                    "country": "US",
                    "name": "A. Klaassen",
                    "email": "example@gmail.com"
                },
                "reference": "daslvcgbaieh"
            }
        }
    }
}'
4. Retrieve txn details 
curl --location 'http://localhost:8080/payments/pay_yyhXMuPPvXTjFYbFM4sS?force_sync=true' \
    --header 'Accept: application/json' \
    --header 'api-key: dev_p9yMRqUZKavXldvbcW8w0GfzR1ynBE2ORUu4FPY3rU82G8OFBx2XOq6ty71UrBIN'

Response

{
    "payment_id": "pay_yyhXMuPPvXTjFYbFM4sS",
    "merchant_id": "postman_merchant_GHAction_011d2d37-e13d-4b83-a896-816c4d097d18",
    "status": "succeeded",
    "amount": 10000,
    "net_amount": 10000,
    "amount_capturable": 0,
    "amount_received": 10000,
    "connector": "adyen",
    "client_secret": "pay_yyhXMuPPvXTjFYbFM4sS_secret_8dripBlpBRYSlLwBD3qi",
    "created": "2024-08-26T06:10:37.599Z",
    "currency": "USD",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "abcdef123@gmail.com",
        "phone": "999999999",
        "phone_country_code": "+65"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": "on_session",
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "bank_debit",
    "payment_method_data": {
        "bank_debit": {
            "ach": {
                "account_number": "****8669",
                "routing_number": "121***358",
                "bank_account_holder_name": null,
                "bank_name": null,
                "bank_type": null,
                "bank_holder_type": null
            }
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "John",
            "last_name": "Doe"
        },
        "phone": null,
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": null,
            "last_name": null
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": "abcdef123@gmail.com",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://duck.com/",
    "authentication_type": "three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "ach",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "L53M262VC5XBZX65",
    "frm_message": null,
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_yyhXMuPPvXTjFYbFM4sS_1",
    "payment_link": null,
    "profile_id": "pro_gsiLSYq37GwBEhz0ev26",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_xR9f8EBOdN45KgAkTCLx",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-08-26T06:25:37.599Z",
    "fingerprint": null,
    "browser_info": {
        "language": "nl-NL",
        "time_zone": 0,
        "ip_address": "127.0.0.1",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 1536,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "screen_height": 723,
        "java_script_enabled": true
    },
    "payment_method_id": "pm_iBk2oopRt92TdFdZdLCH",
    "payment_method_status": "active",
    "updated": "2024-08-26T06:10:40.328Z",
    "charges": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null
}

image
image

5. Bank Debit - Bacs 
curl --location 'http://localhost:8080/payments' \
  --header 'Content-Type: application/json' \
  --header 'Accept: application/json' \
  --header 'api-key: dev_JCI3dRg06RjMyOrBDO81euxfOykGXlA9zgW4Cf2iXGy2xwexsY6GOSH5sI41GugN' \
  --data-raw '{
      "amount": 10000,
      "currency": "USD",
      "confirm": true,
      "capture_method": "automatic",
      "capture_on": "2022-09-10T10:11:12Z",
      "customer_id": "StripeCustomer",
      "email": "abcdef123@gmail.com",
      "name": "John Doe",
      "phone": "999999999",
      "phone_country_code": "+65",
      "description": "Its my first payment request",
      "authentication_type": "three_ds",
      "return_url": "https://duck.com",
      "setup_future_usage": "on_session",
      "customer_acceptance": {
          "acceptance_type": "offline",
          "accepted_at": "1963-05-03T04:07:52.723Z",
          "online": {
              "ip_address": "127.0.0.1",
              "user_agent": "amet irure esse"
          }
      },
      "billing": {
          "address": {
              "line1": "1467",
              "line2": "Harrison Street",
              "line3": "Harrison Street",
              "city": "San Fransico",
              "state": "California",
              "zip": "94122",
              "country": "US"
          }
      },
      "browser_info": {
          "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
          "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
          "language": "nl-NL",
          "color_depth": 24,
          "screen_height": 723,
          "screen_width": 1536,
          "time_zone": 0,
          "java_enabled": true,
          "java_script_enabled": true,
          "ip_address": "127.0.0.1"
      },
      "shipping": {
          "address": {
              "line1": "1467",
              "line2": "Harrison Street",
              "line3": "Harrison Street",
              "city": "San Fransico",
              "state": "California",
              "zip": "94122",
              "country": "US",
              "first_name": "John",
              "last_name": "Doe"
          }
      },
      "statement_descriptor_name": "joseph",
      "statement_descriptor_suffix": "JS",
      "metadata": {
          "udf1": "value1",
          "new_customer": "true",
          "login_date": "2019-09-10T10:11:12Z"
      },
      "payment_method": "bank_debit",
      "payment_method_type": "ach",
      "payment_method_data": {
          "bank_debit": {
              "ach_bank_debit": {
                  "account_number": "40308669",
                  "routing_number": "121000358",
                  "sort_code": "560036",
                  "shopper_email": "example@gmail.com",
                  "card_holder_name": "joseph Doe",
                  "bank_account_holder_name": "David Archer",
                  "billing_details": {
                      "houseNumberOrName": "50",
                      "street": "Test Street",
                      "city": "Amsterdam",
                      "stateOrProvince": "NY",
                      "postalCode": "12010",
                      "country": "US",
                      "name": "A. Klaassen",
                      "email": "example@gmail.com"
                  },
                  "reference": "daslvcgbaieh"
              }
          }
      }
  }'
6. Retrieve txn details 
curl --location 'http://localhost:8080/payments/pay_alnXBCvp6f9jl6ZqWo1e?force_sync=true' \
    --header 'Accept: application/json' \
    --header 'api-key: dev_p9yMRqUZKavXldvbcW8w0GfzR1ynBE2ORUu4FPY3rU82G8OFBx2XOq6ty71UrBIN'

Response

{
    "payment_id": "pay_alnXBCvp6f9jl6ZqWo1e",
    "merchant_id": "postman_merchant_GHAction_011d2d37-e13d-4b83-a896-816c4d097d18",
    "status": "processing",
    "amount": 100,
    "net_amount": 100,
    "amount_capturable": 0,
    "amount_received": null,
    "connector": "adyen",
    "client_secret": "pay_alnXBCvp6f9jl6ZqWo1e_secret_dwQNXM4uPcs7PNeyxPnN",
    "created": "2024-08-26T06:11:42.510Z",
    "currency": "GBP",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "abcdef123@gmail.com",
        "phone": "999999999",
        "phone_country_code": "+65"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": "on_session",
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "bank_debit",
    "payment_method_data": {
        "bank_debit": {
            "bacs": {
                "account_number": "****8669",
                "sort_code": "56**36",
                "bank_account_holder_name": null
            }
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "John",
            "last_name": "Doe"
        },
        "phone": null,
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "GB",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": null,
            "last_name": null
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": "abcdef123@gmail.com",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://duck.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "bacs",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "FWJ6KDDCFJK94875",
    "frm_message": null,
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_alnXBCvp6f9jl6ZqWo1e_1",
    "payment_link": null,
    "profile_id": "pro_gsiLSYq37GwBEhz0ev26",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_xR9f8EBOdN45KgAkTCLx",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-08-26T06:26:42.510Z",
    "fingerprint": null,
    "browser_info": {
        "language": "nl-NL",
        "time_zone": 0,
        "ip_address": "127.0.0.1",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 1536,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "screen_height": 723,
        "java_script_enabled": true
    },
    "payment_method_id": "pm_FWrcMK5kATtjyw9i0hqP",
    "payment_method_status": "inactive",
    "updated": "2024-08-26T06:11:48.748Z",
    "charges": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null
}

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m linked an issue Aug 21, 2024 that may be closed by this pull request
[FEATURE] Payments and it's webhook response to contain non-card payment method details #5652
Closed
2 tasks
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Aug 21, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 3 of 10 files.

Overall, the semantic diff is 6% smaller than the GitHub diff.

Filename Status
✔️ crates/router/src/core/payments/helpers.rs 44.98% smaller
❔ crates/openapi/src/openapi.rs Unsupported file format
❔ crates/openapi/src/openapi_v2.rs Unsupported file format
❔ crates/masking/src/lib.rs Unsupported file format
❔ crates/masking/src/masked_string.rs Unsupported file format
✔️ crates/hyperswitch_domain_models/src/payment_method_data.rs 0.99% smaller
❔ crates/api_models/src/payments.rs Unsupported file format
❔ crates/api_models/src/payments/additional_info.rs Unsupported file format
✔️ api-reference-v2/openapi_spec.json Analyzed
❔ api-reference/openapi_spec.json Unsupported file format

@kashif-m kashif-m self-assigned this Aug 22, 2024
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 22, 2024
@kashif-m kashif-m changed the title wip: populate payment method details in payments response feat: populate payment method details in payments response Aug 22, 2024
@kashif-m kashif-m marked this pull request as ready for review August 22, 2024 09:17
@kashif-m kashif-m requested review from a team as code owners August 22, 2024 09:17
@kashif-m kashif-m added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer A-payments Area: payments labels Aug 22, 2024
@kashif-m
Merge remote-tracking branch 'origin/main' into 5652-feature-payments…
53b089a 
…-and-its-webhook-response-to-contain-non-card-payment-method-details
@kashif-m
chore: hack fixes
92713ab
@kashif-m
Merge remote-tracking branch 'origin/main' into 5652-feature-payments…
bca2c86 
…-and-its-webhook-response-to-contain-non-card-payment-method-details
@Sarthak1799
Copy link
Contributor

Payment method data changes look fine.
Do get a review from payment-core.

SanchithHegde
SanchithHegde previously approved these changes Aug 23, 2024
View reviewed changes
jarnura
jarnura requested changes Aug 25, 2024
View reviewed changes
crates/api_models/src/payments/additional_info.rs Outdated Show resolved Hide resolved
crates/api_models/src/payments/additional_info.rs Outdated Show resolved Hide resolved
crates/api_models/src/payments/additional_info.rs Outdated Show resolved Hide resolved
@kashif-m
Merge remote-tracking branch 'origin/main' into 5652-feature-payments…
531897e 
…-and-its-webhook-response-to-contain-non-card-payment-method-details
@kashif-m
refactor: resolve comments
0412f94
Sarthak1799
Sarthak1799 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@Sarthak1799 Sarthak1799 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Payment method data changes LGTM

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 32db5dd Aug 26, 2024
22 checks passed
@Gnanasundari24 Gnanasundari24 deleted the 5652-feature-payments-and-its-webhook-response-to-contain-non-card-payment-method-details branch August 26, 2024 16:56
pixincreate added a commit that referenced this pull request Aug 27, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into add-auto-retry
b8d6398 
* 'main' of github.com:juspay/hyperswitch:
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
pixincreate added a commit that referenced this pull request Aug 27, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into add-cypress-ci
3c2515e 
* 'main' of github.com:juspay/hyperswitch: (134 commits)
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
  feat(customer_v2):  added list customer v2 end point (#5517)
  feat(business_profile): add tax_connector_id column in business_profile table (#5576)
  chore: create v2 route for organization (#5679)
  refactor(payments_response): remove setter from payments response (#5676)
  feat(payment_methods_v2): Payment methods v2 API models (#5564)
  chore(version): 2024.08.26.0
  feat(connector): [Adyen] add dispute flows for adyen connector (#5514)
  chore(version): 2024.08.23.0
  ...
pixincreate added a commit that referenced this pull request Aug 27, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into cypress-api…
3bb8643 
…-key-check

* 'main' of github.com:juspay/hyperswitch:
  feat(core): Add mTLS certificates for each request (#5636)
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
  feat(customer_v2):  added list customer v2 end point (#5517)
  feat(business_profile): add tax_connector_id column in business_profile table (#5576)
  chore: create v2 route for organization (#5679)
  refactor(payments_response): remove setter from payments response (#5676)
  feat(payment_methods_v2): Payment methods v2 API models (#5564)
  chore(version): 2024.08.26.0
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 1, 2024
lsampras added a commit that referenced this pull request Sep 3, 2024
@lsampras
Revert "feat: populate payment method details in payments response (#…
b9807c6 
…5661)"

This reverts commit 32db5dd.
@lsampras lsampras mentioned this pull request Sep 3, 2024
Merged
This was referenced Sep 3, 2024
Merged
Merged
kashif-m added a commit that referenced this pull request Sep 5, 2024
@kashif-m
feat: populate payment method details in payments response (#5661)
eeb97e0 
(cherry picked from commit 32db5dd)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Sarthak1799 Sarthak1799 Sarthak1799 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@kashif-m kashif-m

Labels
A-core Area: Core flows A-payments Area: payments M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Payments and it's webhook response to contain non-card payment method details
5 participants
@kashif-m @Sarthak1799 @jarnura @SanchithHegde @Gnanasundari24