Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix etcd peer URL to support ipv6 #5181

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

ncopa
Copy link
Collaborator

@ncopa ncopa commented Nov 5, 2024

IPv6 URL need to have brackets [] around the ipv6 to separate it from the port. Eg https://[xx:yy:zz]:2380

Fix this by using net/url's String() formatter.

Description

Fixes #5180

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

IPv6 URL need to have brackets [] around the ipv6 to separate it from
the port. Eg https://[xx:yy:zz]:2380

Fix this by using net/url's String() formatter.

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
@ncopa ncopa requested review from a team as code owners November 5, 2024 13:34
@ncopa ncopa requested review from kke and juanluisvaladas November 5, 2024 13:34
@ncopa ncopa enabled auto-merge November 5, 2024 14:26
@ncopa ncopa added bug Something isn't working area/network component/etcd backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch and removed backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch labels Nov 5, 2024
@ncopa ncopa merged commit 09ac812 into k0sproject:main Nov 8, 2024
96 checks passed
@k0s-bot
Copy link

k0s-bot commented Nov 8, 2024

Backport failed for release-1.29, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.29
git worktree add -d .worktree/backport-5181-to-release-1.29 origin/release-1.29
cd .worktree/backport-5181-to-release-1.29
git switch --create backport-5181-to-release-1.29
git cherry-pick -x 1469e0c5142b49d2be6abd79e56eb9580f716537

@k0s-bot
Copy link

k0s-bot commented Nov 8, 2024

Successfully created backport PR for release-1.30:

@k0s-bot
Copy link

k0s-bot commented Nov 8, 2024

Successfully created backport PR for release-1.31:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/network backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch bug Something isn't working component/etcd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etcd component does not support IPv6 only addresses
3 participants