Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Backport release-1.29] Fix etcd peer URL to support ipv6 #5192

Closed
wants to merge 1 commit into from
Closed

[Backport release-1.29] Fix etcd peer URL to support ipv6 #5192

wants to merge 1 commit into from

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Nov 8, 2024

@ncopa @twz123
Fix etcd peer URL to support ipv6
e013860 
IPv6 URL need to have brackets [] around the ipv6 to separate it from
the port. Eg https://[xx:yy:zz]:2380

Fix this by using net/url's String() formatter.

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
(cherry picked from commit 1469e0c)
(cherry picked from commit 312a8c3)
@twz123 twz123 added bug Something isn't working area/network labels Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Dec 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Jan 9, 2025
@twz123 twz123 closed this Jan 31, 2025
@twz123 twz123 deleted the backport-5190-to-release-1.29 branch January 31, 2025 10:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/network bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @ncopa