Fix some linting issues #123
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerald Pape <gerald@giantswarm.io>
ubergesundheit
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
5 tasks
|
Thanks for the PR! We have it open on #84 but we are not sure if we will change it given it's a breaking change. /cc @zroubalik |
|
Are you fine with me leaving this one open since it also fixes a trailing white space? |
|
Can you get the role change out so we can merge the other fixes already? |
Signed-off-by: Gerald Pape <gerald@giantswarm.io>
|
Sure. See 0c01d36 |
tomkerkhove
approved these changes
Feb 17, 2021
|
Thank you for this contribution @ubergesundheit! |
wozniakjan
added a commit
to wozniakjan/keda-charts
that referenced
this pull request
Feb 21, 2025
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves some linting issues I noticed after running
ct lint --validate-maintainers=false --charts=keda/(https://github.com/helm/chart-testing)Checklist