Change ClusterRoleBinding name to align with industry standard

[ubergesundheit]

This PR changes the name of the ClusterRoleBinding. This appeared after running https://github.com/helm/chart-testing on the kedacore/charts repository.

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• Tests have been added
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified) Fix some linting issues charts#123
• A PR is opened to update the documentation on (repo) (if applicable)
• Changelog has been updated

[tomkerkhove]

Same applies here: kedacore/charts#123 (comment)

[ubergesundheit]

I'll leave this PR open until kedacore/charts#84 is merged if you don't mind

[ahmelsayed]

@tomkerkhove is this good to merge?

[tomkerkhove]

This relates to kedacore/charts#84, shall we go ahead with this @zroubalik?

This could be considered as breaking, though.

[zroubalik]

@tomkerkhove I think that we can go with this one, but should mention somewhere, that there might be a leftover ClusterRoleBinding keda:system:auth-delegator when users will be updating from KEDA < 2.4

[tomkerkhove]

Sounds good to me - @ubergesundheit would you mind rebasing main branch and adding an extra note to the changelog please?

[ubergesundheit]

Sounds good to me - @ubergesundheit would you mind rebasing main branch and adding an extra note to the changelog please?

sure :)

[ubergesundheit]

The changelog entry now reads Fix keda-system-auth-delegatorClusterRoleBinding name ([#1616](https://github.com/kedacore/keda/pull/1616). Upgrading may leave a stray ClusterRoleBinding with the old namekeda:system:auth-delegator behind.

[zroubalik]

The changelog entry now reads Fix keda-system-auth-delegatorClusterRoleBinding name ([#1616](https://github.com/kedacore/keda/pull/1616). Upgrading may leave a stray ClusterRoleBinding with the old namekeda:system:auth-delegator behind.

Would you mind moving it to ## Breaking Changes section? thx!

[ubergesundheit]

Are you going to squash this PR? Should I squash?

[tomkerkhove]

No it's ok - I'll squash it!

[tomkerkhove]

Are you willing to update our chart as well @ubergesundheit?

[ubergesundheit]

@tomkerkhove you already have an open PR (created by you 😛 ) kedacore/charts#84

[tomkerkhove]

😂

I'm a moron - Thank you!

[gldraphael]

Hi, I'm currently on v2.3.2

Running a kubectl get clusterrolebindings returns the following:

NAME                                                   ROLE                                                               AGE
keda-operator                                          ClusterRole/keda-operator                                          50d
keda-operator-hpa-controller-external-metrics          ClusterRole/keda-operator-external-metrics-reader                  50d
keda-operator:system:auth-delegator                    ClusterRole/system:auth-delegator                                  50d

Is keda:system:auth-delegator a typo? Was it meant to be keda-operator:system:auth-delegator instead?

---

Edit:

It seems like the default is keda-operator:

https://github.com/kedacore/charts/blob/93e2fdc563974502f0d93707e4651c2f9bc63db3/keda/values.yaml#L23
https://github.com/kedacore/charts/blob/1e44265c3de39fb713d8ee278e86f17aa94c8380/keda/values.yaml#L15