Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support pod conditions for pending job count calculation #1970

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Support pod conditions for pending job count calculation #1970

merged 3 commits into from
Aug 3, 2021

Conversation

yaronya
Copy link
Contributor

@yaronya yaronya commented Jul 20, 2021 •
edited
Loading

Added the pendingPodConditions setting for which users can pass a list of Pod Conditions which Keda will consider when calculating the pending job count.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable) - pendingPodConditions documentation keda-docs#496
  • Changelog has been updated

Resolves #1963

Signed-off-by: Yaron Yarimi yaron.yarimi@env0.com

@zroubalik zroubalik requested a review from TsuyoshiUshio July 22, 2021 08:11
@yaronya yaronya mentioned this pull request Aug 1, 2021
Merged
1 task
@yaronya yaronya marked this pull request as ready for review August 1, 2021 15:23
@yaronya yaronya marked this pull request as draft August 1, 2021 15:33
@yaronya
Support pod conditions for pending job count calculation
e33dcc5 
Signed-off-by: Yaron Yarimi <yaron.yarimi@env0.com>
@yaronya yaronya marked this pull request as ready for review August 2, 2021 10:21
zroubalik
zroubalik reviewed Aug 2, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a very minor nit 😅

TsuyoshiUshio
TsuyoshiUshio approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@TsuyoshiUshio TsuyoshiUshio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Looks good to me.

@yaronya @zroubalik
Update pkg/scaling/executor/scale_jobs.go
8b01da4 
Signed-off-by: Yaron Yarimi <yaronya@users.noreply.github.com>

Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
@yaronya yaronya requested a review from zroubalik August 3, 2021 06:05
zroubalik
zroubalik approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik added this to the v2.4.0 milestone Aug 3, 2021
@yaronya
Copy link
Contributor Author

yaronya commented Aug 3, 2021 •
edited
Loading

@zroubalik @TsuyoshiUshio thanks 🙏
Any estimation on when 2.4.0 will be released?

@zroubalik
Copy link
Member

@yaronya later this week if everything will fine :)

@zroubalik zroubalik merged commit 08cdde0 into kedacore:main Aug 3, 2021
@zroubalik zroubalik mentioned this pull request Aug 4, 2021
Merged
2 tasks
TsuyoshiUshio pushed a commit that referenced this pull request Aug 6, 2021
@yaronya @zroubalik
Support pod conditions for pending job count calculation (#1970)
3e3acc2 
Signed-off-by: Yaron Yarimi <yaronya@users.noreply.github.com>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
@etamarw etamarw mentioned this pull request Sep 12, 2021
Closed
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
@yaronya @zroubalik @nilayasiktoprak
Support pod conditions for pending job count calculation (kedacore#1970)
f3c625e 
Signed-off-by: Yaron Yarimi <yaronya@users.noreply.github.com>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@TsuyoshiUshio TsuyoshiUshio TsuyoshiUshio approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees

@zroubalik zroubalik

Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Support Pod conditions for calculating PendingJobCount in accurate scaling startegy
3 participants
@yaronya @zroubalik @TsuyoshiUshio