Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding pendingPodConditions field to ScaledJob CRD #2009

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Aug 4, 2021

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

ScaledJob CRD hasn't been regenerated as part of #1970
Thus pendingPodConditions feature wouldn't be available to the users. This PR fixes that.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Changelog has been updated

Fixes #1963

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik requested a review from ahmelsayed as a code owner August 4, 2021 14:19
@zroubalik zroubalik requested a review from tomkerkhove August 4, 2021 14:19
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik
Copy link
Member Author

@yaronya FYI :)

@ahmelsayed ahmelsayed merged commit eacf6d8 into kedacore:main Aug 4, 2021
TsuyoshiUshio pushed a commit that referenced this pull request Aug 6, 2021
Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Pod conditions for calculating PendingJobCount in accurate scaling startegy
3 participants