Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bump deps #2559

Merged
merged 1 commit into from
Jan 25, 2022
Merged

bump deps #2559

merged 1 commit into from
Jan 25, 2022

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates #2503

@zroubalik zroubalik requested a review from a team as a code owner January 25, 2022 13:09
@zroubalik
Copy link
Member Author

zroubalik commented Jan 25, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik
Copy link
Member Author

There will be a follow up PR once kubernetes-sigs/custom-metrics-apiserver#97 is merged.

@zroubalik
Copy link
Member Author

zroubalik commented Jan 25, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik zroubalik added this to the v2.6.0 milestone Jan 25, 2022
@zroubalik zroubalik mentioned this pull request Jan 25, 2022
Closed
5 tasks
@zroubalik
Copy link
Member Author

zroubalik commented Jan 25, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

JorTurFer
JorTurFer approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Only one small nit

pkg/scalers/gcp_pub_sub_scaler.go Outdated Show resolved Hide resolved
bump deps
12aa8d8 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik
Copy link
Member Author

zroubalik commented Jan 25, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik zroubalik merged commit f6e4be8 into kedacore:main Jan 25, 2022
@tomkerkhove
Copy link
Member

Thanks! 🥇

@zroubalik
Copy link
Member Author

Thanks! 🥇

No need to thank. Most likely there will be a round two 🤦‍♂️😂

@JorTurFer
Copy link
Member

❤️ ❤️ 🥇 ❤️ ❤️

markrzasa pushed a commit to markrzasa/keda that referenced this pull request Jan 27, 2022
@zroubalik @markrzasa
bump deps (kedacore#2559)
233bfd1 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
markrzasa pushed a commit to markrzasa/keda that referenced this pull request Jan 27, 2022
@zroubalik @markrzasa
bump deps (kedacore#2559)
3f34337 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
markrzasa pushed a commit to markrzasa/keda that referenced this pull request Jan 27, 2022
@zroubalik @markrzasa
bump deps (kedacore#2559)
bed4284 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zroubalik @tomkerkhove @JorTurFer