-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
bump deps & k8s deps to v0.23.3 #97
Conversation
Hi @zroubalik. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
/ok-to-test |
Seems like there is an issue during build: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_custom-metrics-apiserver/97/pull-custom-metrics-apiserver-build-test-adapter/1486279390277931008 As far as I can tell it seems related to kubernetes-sigs/controller-tools#643 which looks solvable by updating go to 1.17, could you look into that? |
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, tomkerkhove, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
Can we have a new release with these deps?