Adjusting WalletRegistry to Threshold IApplication rewards API #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdyraga
commented
Apr 26, 2022
| @@ -630,6 +630,14 @@ | |||
| "@openzeppelin/contracts" "^4.3.2" | |||
| "@thesis/solidity-contracts" "github:thesis/solidity-contracts#4985bcf" | |||
|
|
|||
There was a problem hiding this comment.
Once #2953 is merged, we need to update @keep-network/random-beacon dependency to eliminate the sortition pool entry above.
There was a problem hiding this comment.
Let's merge #2956 first. Then, once a new @keep-network/random-beacon NPM package is published, I will update this PR.
The most recent version includes improvements to rewards API. First, it is possible to fetch the amount of rewards withdrawable. Second, withdrawRewards function returns the amount withdrawn.
`WalletRegistry.withdrawRewards` emits `RewardsWithdrawn` event informing about the amount of tokens withdrawn in the transaction. `WalletRegistry.availableRewards` informs about the amount of reward tokens available for withdrawal for the staking provider.
SortitionPool is trusted contract so there is no risk of re-entrancy. The event emitted after the call needs the amount and amount is returned by the SortitionPool.
Updated @keep-network/random-beacon and @threshold-network/solidity-contracts dependencies to the most recent development versions. The most recent versions are both aligned around reward-related changes in IApplication interface.
This event is now declared as a part of IApplication interface, WalletRegistry extends.
|
#2953 got merged so I rebased this PR over |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2953; Keeping it as a draft PR until #2953 is not merged.Refs threshold-network/solidity-contracts#89
Refs #2935
See threshold-network/solidity-contracts#95
See keep-network/sortition-pools#162
See keep-network/sortition-pools#163
WalletRegistry.withdrawRewardsemitsRewardsWithdrawnevent informing aboutthe amount of tokens withdrawn in the transaction.
WalletRegistry.availableRewardsinforms about the amount of reward tokensavailable for withdrawal for the staking provider.