SortitionPool.withdrawRewards returns the amount of rewards withdrawn #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to emit an event in application contract with the amount of rewards withdrawn. It will be helpful for the dApp when rendering rewards page.
| { | ||
| uint32 id = getOperatorID(operator); | ||
| Rewards.updateOperatorRewards(id, uint32(getPoolWeight(operator))); | ||
| uint96 earned = Rewards.withdrawOperatorRewards(id); | ||
| rewardToken.transfer(beneficiary, uint256(earned)); | ||
| return earned; |
There was a problem hiding this comment.
Not going to block this PR for it, but I just merged #162 that uses this function in tests.
Now that we have a return value, we should assert that the return value of withdrawRewards is correct!
beaurancourt
approved these changes
Apr 25, 2022
This was referenced Apr 26, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #162; Please do not merge until #162 is not inmain.This allows to emit an event in application contract with the amount of
rewards withdrawn. It will be helpful for the dApp when rendering
rewards page.