Welcome screen redesign #292
Conversation
src/gui/WelcomeWidget.cpp
Outdated
| @@ -18,13 +18,52 @@ | |||
| #include "WelcomeWidget.h" | |||
| #include "ui_WelcomeWidget.h" | |||
|
|
|||
| #include <QDebug> | |||
There was a problem hiding this comment.
@TheZ3ro I guess that was used for debugging while coding the feature?
There was a problem hiding this comment.
Wooops, I will force push
|
One more thing: You should either spell Database with a lowercase D or make everything title case. |
TheZ3ro
force-pushed
the
feature/redesign-welcome-screen
branch
from
749d250 to
afd1fac
Compare
|
This is the UI on MacOs.
The Also, maybe we could hide the Good job @TheZ3ro !! |
TheZ3ro
force-pushed
the
feature/redesign-welcome-screen
branch
from
afd1fac to
ee981c4
Compare
|
I have the feeling that widget sizes on OS X are quite messed up in general. The keyfile dropdown in the unlock dialog is also not the same size as the password field. And the password fields in the new database widget are tiny. I think we need to polish all that a little for 2.2.0. |
|
Oh, I know why the KeePass1 button is smaller. It's inside a horizontal layout with the (hide) CSV button. |
src/gui/WelcomeWidget.ui
Outdated
| <brush brushstyle="SolidPattern"> | ||
| <color alpha="255"> | ||
| <red>0</red> | ||
| <green>255</green> |
There was a problem hiding this comment.
I would remove that color. The button should have the system's default button color.
The green is really lurid and also very surprising. When the button has focus, it has a nice light blue on my system, but when it loses focus, it's suddenly shocking green.
There was a problem hiding this comment.
Seems that this wasn't reverted in the previus force-push
src/gui/WelcomeWidget.ui
Outdated
| <item> | ||
| <widget class="QPushButton" name="buttonImportKeePass1"> | ||
| <property name="text"> | ||
| <string>Import from KeePass1</string> |
There was a problem hiding this comment.
The file filter in the open dialog has a space between "KeePass" and "1". I suggest adding one here, too.
- Added YubiKey 2FA integration for unlocking databases [#127] - Added TOTP support [#519] - Added CSV import tool [#146, #490] - Added KeePassXC CLI tool [#254] - Added diceware password generator [#373] - Added support for entry references [#370, #378] - Added support for Twofish encryption [#167] - Enabled DEP and ASLR for in-memory protection [#371] - Enabled single instance mode [#510] - Enabled portable mode [#645] - Enabled database lock on screensaver and session lock [#545] - Redesigned welcome screen with common features and recent databases [#292] - Multiple updates to search behavior [#168, #213, #374, #471, #603, #654] - Added auto-type fields {CLEARFIELD}, {SPACE}, {{}, {}} [#267, #427, #480] - Fixed auto-type errors on Linux [#550] - Prompt user prior to executing a cmd:// URL [#235] - Entry attributes can be protected (hidden) [#220] - Added extended ascii to password generator [#538] - Added new database icon to toolbar [#289] - Added context menu entry to empty recycle bin in databases [#520] - Added "apply" button to entry and group edit windows [#624] - Added macOS tray icon and enabled minimize on close [#583] - Fixed issues with unclean shutdowns [#170, #580] - Changed keyboard shortcut to create new database to CTRL+SHIFT+N [#515] - Compare window title to entry URLs [#556] - Implemented inline error messages [#162] - Ignore group expansion and other minor changes when making database "dirty" [#464] - Updated license and copyright information on souce files [#632] - Added contributors list to about dialog [#629]
phoerious
added
pr: new feature
Description
Welcome Screen redesign
Motivation and Context
A nicer welcome screen for new users
How Has This Been Tested?
Manually on Linux (should work no problem on other platforms)
Screenshots (if appropriate):
Types of changes
Checklist: