Add "Apply" button to entry and group edit windows #624
Conversation
| @@ -102,7 +103,10 @@ void EditWidget::setReadOnly(bool readOnly) | |||
| m_ui->buttonBox->setStandardButtons(QDialogButtonBox::Close); | |||
| } | |||
| else { | |||
| m_ui->buttonBox->setStandardButtons(QDialogButtonBox::Ok | QDialogButtonBox::Cancel); | |||
| m_ui->buttonBox->setStandardButtons(QDialogButtonBox::Ok | QDialogButtonBox::Cancel | QDialogButtonBox::Apply); | |||
There was a problem hiding this comment.
@droidmonkey maybe nitpicking, but I'd place the Apply before the Cancel.
There was a problem hiding this comment.
@louib It seems Qt ignores the order of the values and sets it according to the platform defaults:
https://doc.qt.io/qt-5/qmessagebox.html#the-property-based-api
src/gui/EditWidget.cpp
Outdated
| m_ui->buttonBox->setStandardButtons(QDialogButtonBox::Ok | QDialogButtonBox::Cancel); | ||
| m_ui->buttonBox->setStandardButtons(QDialogButtonBox::Ok | QDialogButtonBox::Cancel | QDialogButtonBox::Apply); | ||
| // Find and connect the apply button | ||
| QPushButton *applyButton = m_ui->buttonBox->button(QDialogButtonBox::Apply); |
There was a problem hiding this comment.
@droidmonkey QPushButton* applyButton
| @@ -66,7 +66,7 @@ | |||
| <item> | |||
| <widget class="QDialogButtonBox" name="buttonBox"> | |||
| <property name="standardButtons"> | |||
| <set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set> | |||
| <set>QDialogButtonBox::Apply|QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set> | |||
There was a problem hiding this comment.
@droidmonkey we could also preserve the same order for the Ok Apply and Cancel buttons here.
|
@droidmonkey the new button works great! However, it appears the button stays pushed until a click is made somewhere in the window. Would it be possible to never leave it pushed?
Notice also that the Ok button is always pushed. I tested and it's the same thing on the current develop branch. Do you recall if there was a reason for that? |
|
@louib the QDialogButtonBox handles all the particulars when it comes to button behavior and ordering. I am not aware of anything special we are doing that would cause the always pushed look to occur. |
- Added YubiKey 2FA integration for unlocking databases [#127] - Added TOTP support [#519] - Added CSV import tool [#146, #490] - Added KeePassXC CLI tool [#254] - Added diceware password generator [#373] - Added support for entry references [#370, #378] - Added support for Twofish encryption [#167] - Enabled DEP and ASLR for in-memory protection [#371] - Enabled single instance mode [#510] - Enabled portable mode [#645] - Enabled database lock on screensaver and session lock [#545] - Redesigned welcome screen with common features and recent databases [#292] - Multiple updates to search behavior [#168, #213, #374, #471, #603, #654] - Added auto-type fields {CLEARFIELD}, {SPACE}, {{}, {}} [#267, #427, #480] - Fixed auto-type errors on Linux [#550] - Prompt user prior to executing a cmd:// URL [#235] - Entry attributes can be protected (hidden) [#220] - Added extended ascii to password generator [#538] - Added new database icon to toolbar [#289] - Added context menu entry to empty recycle bin in databases [#520] - Added "apply" button to entry and group edit windows [#624] - Added macOS tray icon and enabled minimize on close [#583] - Fixed issues with unclean shutdowns [#170, #580] - Changed keyboard shortcut to create new database to CTRL+SHIFT+N [#515] - Compare window title to entry URLs [#556] - Implemented inline error messages [#162] - Ignore group expansion and other minor changes when making database "dirty" [#464] - Updated license and copyright information on souce files [#632] - Added contributors list to about dialog [#629]
Description
Add's an "Apply" buttons to both the entry and group edit windows. Implements #509.
Motivation and context
Often times you want to save your changes without exiting the edit windows.
How has this been tested?
Manually and with updated GUI tests.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]