Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Single-character non-ASCII TEXT_BLOCK input crashes the service. #1328

Closed
2 tasks
t184256 opened this issue Oct 28, 2024 · 4 comments
Closed
2 tasks

Single-character non-ASCII TEXT_BLOCK input crashes the service. #1328

t184256 opened this issue Oct 28, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@t184256
Copy link

t184256 commented Oct 28, 2024

Developer TODO (don't remove)

  • write tests. put issue number in comment
  • update documentation

Discord message link/email recipient

Describe the bug
Single-character non-ASCII TEXT_BLOCK input crashes the service.

To Reproduce
Steps to reproduce the behavior: On Android 14 (with that new-fangled proxy thing) use TEXT_BLOCK with a single non-ASCII character.
mappings_generated.json. Two characters work fine because they take a different code path.

Expected behavior
Single character is inputted fine.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Samsung S10e
  • Android version: Android 14 (LineageOS)
  • Also observed on Samsung Tab S8 Ultra / Stock Android 14

Additional context
IMO, when keyCharacterMap.getEvents(chars) in inputTextRelayService returns null, there should be a fallback.

@t184256
Copy link
Author

t184256 commented Oct 28, 2024

Such crashes were never a problem on a Samsung Fold 2 / Android 13.

@sds100 sds100 added this to Key Mapper Nov 7, 2024
@sds100 sds100 added this to the Version 2.6 milestone Nov 7, 2024
@sds100 sds100 moved this to In progress in Key Mapper Nov 7, 2024
@sds100
Copy link
Collaborator

sds100 commented Nov 7, 2024

Can you try this apk?
keymapper-2.6.3-debug.apk.zip

@t184256
Copy link
Author

t184256 commented Nov 12, 2024

Yes, with that build no longer crashes and outputs cz/ru just fine. Thank you!

@sds100
Copy link
Collaborator

sds100 commented Nov 22, 2024

great! Will mark as fixed

@sds100 sds100 closed this as completed Nov 22, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Key Mapper Nov 22, 2024
@sds100 sds100 modified the milestones: Version 2.6, 2.7 Dec 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants